Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for external links #85

Open
jn0 opened this issue Dec 21, 2016 · 2 comments
Open

add support for external links #85

jn0 opened this issue Dec 21, 2016 · 2 comments

Comments

@jn0
Copy link

jn0 commented Dec 21, 2016

This

<pagelist>
  * [[https://site1.example.com|good service]]
  * [[http://site2.example.com|bad service]]
</pagelist>

will produce an ugly output...
I'd like to have it available too here 👋

@lpaulsen93
Copy link
Member

What do you mean with "ugly output"?
If you mean that the link (e.g. site1.example.com) is displayed instead of the link text (e.g. good service) then a fix is in progress, please see #95.

Please confirm or describe your problem in more detail. Thanks.

@lprobsth
Copy link

I think that this is related to this line:

$content = '<a href="'.wl($id).($this->page['section'] ? '#'.$this->page['section'] : '').

Currently pagelist ist not able to produce lists with external links. I think it would be possible to regex for "http[s]" in the page id and then just output the id content as a hyperlink. Another possibility would be an extra config flag for external link parsing...

"https://gitlab.com/" gives me "//gitlab.com/ as link text and "https://yourdomain.com/https///gitlab.com/"...

lprobsth added a commit to lprobsth/plugin-pagelist that referenced this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants