Implemented multiarch support #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Grinco <[email protected]>
Signed-off-by: Vadim Grinco <[email protected]>
Signed-off-by: Vadim Grinco <[email protected]>
|
@doitandbedone anything I can do to help merge this? |
Signed-off-by: Vadim Grinco <[email protected]>
|
Hello @grinco , really appreciate you taking the time to do all this! Ideally we want to stay with an LTS version. It also seems to be now using ffmpeg5 which I'm not sure if it's been verified and fully tested with ispy. Also appreciate the help with the checks on architecture, but ai believe there's some extra steps needed for dockerhub if I remember correctly. But can definitely be used in the future. @ispysoftware any inputs on this? |
|
should be fine with ffmpeg5, would be great if the docker version ran on ARM |
Signed-off-by: Vadim Grinco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
Upgraded the base os to 22.10 for built-in ffmpeg support.
Restructured the Dockerfile a bit to not have to rebuild all layers when playing with the installation script for rapid prototyping.
Tested on both ARM64 and AMD64.
I hope it's useful.