-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll this into the main repo? #108
Comments
did you mean as a monorepo ? |
Yeah, like with docsify-server-render |
Actually I don't really prefer monorepo. It's just because the tools are not so good enough to solve most of the issues. Though I don't mind moving, we may need to change the release script as well. |
Another option is an "umbrella repo" as I like to call it: we can make the packages be git submodules. Then they have their own workflow, but the umbrella repo can test them in unison. What issues did you have? |
I've been using th umbrella approach. For Example: http://guthub.com/lume/lume. See in the Then also click into the sub modules, and you'll see they have their own tests too (f.e. https://github.com/lume/element-behaviors/blob/master/.github/workflows/tests.yml) and see that repo's test script in package.json. This has a nice advantage: with an umbrella repo (not a monorepo) you get
|
Yeah, it'll involve some changes |
Would it be worth sticking this in the
packages
folder of the main repo, so it is easier to modify at the same time as other files in the main repo? F.e. updating CLI as well as docs at the same time and making one PR instead of two.The text was updated successfully, but these errors were encountered: