Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration? #1

Open
tbusser opened this issue May 12, 2014 · 8 comments
Open

Configuration? #1

tbusser opened this issue May 12, 2014 · 8 comments

Comments

@tbusser
Copy link

tbusser commented May 12, 2014

Is there anyway to indicate which browser version should be supported like in the original project? For instance I need IE8 support but this is no longer covered by the default last two browser versions.

@roblafeve
Copy link

Ditto

@garthk
Copy link

garthk commented Jan 5, 2015

Yes, but you'll need to write your own plugin until @balupton catches up and can add two lines. Don't worry; it's just two files in your plugins directory, and then you can set plugins.autoprefix.browsers in your docpad.coffee.

@balupton
Copy link
Member

balupton commented Jan 5, 2015

@garthk want push+publish access?

@schlaup
Copy link

schlaup commented Feb 28, 2015

@garthk : You cannot pass browsers in your plugin as requested by @tbusser. I commented and fixed your code. (https://gist.github.com/garthk/e468e708d1c3a4c06571)

@balupton : When you want to implement it in your official plugin, make sure to use my fixes. (Btw, it is really easy - would be nice if the official plugin supported options.)

@StormPooper
Copy link

@schlaup looks good, what does it do if you don't include any options by default? Might be worth specifying a sensible default, like 'last 2 versions, >5%' or something, if there isn't already a default (couldn't find any mention of a default in the core library). Do you fancy creating a pull request for this?

@schlaup
Copy link

schlaup commented Mar 2, 2015

The core has defaults. (They are a bit hidden in its sources.) So, if you do not specify a config, the plugin uses the defaults of autoprefixer. (['> 1%', 'last 2 versions', 'Firefox ESR', 'Opera 12.1'])

I do not code in coffee script. Since it affects only a couple of lines, I hope @balupton can incorporate them without much trouble and without a pull request.

In the meantime you can copy the files from @garthk with my fixes.

Make sure the folder structure in your DocPad project is like this:

plugins
++ autoprefix
++++ src
++++++ autoprefix.plugin.js
++++ package.json

Run "npm install" in the folder and nothing else to do, DocPad automatically sees the plugin in the "plugins" folder.

@balupton
Copy link
Member

v2.1.0 released, still no custom config - happy for a PR

@balupton
Copy link
Member

Really this plugin should become just a postcss plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants