Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: ux: consider supporting to pass custom golang and node images during initialization (via flag?) #167

Open
Dentrax opened this issue May 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link
Contributor

Dentrax commented May 11, 2022

In current implementation, FROM golang:1.17-alpine AS builder and FROM --platform=$BUILDPLATFORM node:17.7-alpine3.14 AS client-builder images are hard-coded values in the boilerplate (Dockerfile). It would be great to override those images during the initialization, for example

$ docker extension init foo --go golang:1.17-alpine --node node:17.7-alpine3.14

Any thoughts?

@benja-M-1
Copy link
Member

Hi @Dentrax 👋 thanks for the suggestion!

The only reason I can think of why those flags would be useful is to avoid to re-build the extension after it has been generated, is it the use case you were thinking about?

@benja-M-1 benja-M-1 added the enhancement New feature or request label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants