Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docker Compose up with build option stops services one by one slowly before restarting them #12310

Open
joaomcarlos opened this issue Nov 21, 2024 · 1 comment

Comments

@joaomcarlos
Copy link

Description

Hi,

This issue only started to come up recently (only noticed it yesterday but before yesterdays update as well)

docker compose up -d --build will:

  • rebuild all services
  • [BUG] stop each service one by one (rather than stopping them in parallel)
  • Recreate + Start the stopped services all together

I have a project with 10 microservices. This means that instead of about 10 seconds building + 4/5 seconds restarting. I get 10 seconds building

Steps To Reproduce

  1. Have a config with N services (DB or RabbitMQ or Kafka + actual services that depend on those, as in, have health checks and start conditions)
  2. Have everything running already
  3. Do a docker system up -d --build (with build will do it regardless if theres actual changes)
  4. What it SLOWLY stop each service one by one instead of stopping all at once and taking a long time

Note: As previously mentioned, we have depend_on conditions on our services, example :

    depends_on:
      migrations:
        condition: service_completed_successfully
      kafka:
        condition: service_healthy
      rabbit:
        condition: service_healthy

Compose Version

Docker Compose version v2.30.3-desktop.1

I am on a MacBook M3 Pro running Sequoia 15.1.1

Docker Environment

➜ docker info
Client:
 Version:    27.3.1
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  ai: Ask Gordon - Docker Agent (Docker Inc.)
    Version:  v0.1.0
    Path:     /Users/joaoc/.docker/cli-plugins/docker-ai
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.18.0-desktop.2
    Path:     /Users/joaoc/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.30.3-desktop.1
    Path:     /Users/joaoc/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.37
    Path:     /Users/joaoc/.docker/cli-plugins/docker-debug
  desktop: Docker Desktop commands (Alpha) (Docker Inc.)
    Version:  v0.0.15
    Path:     /Users/joaoc/.docker/cli-plugins/docker-desktop
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     /Users/joaoc/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.27
    Path:     /Users/joaoc/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.5
    Path:     /Users/joaoc/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.4.0
    Path:     /Users/joaoc/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/joaoc/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.15.0
    Path:     /Users/joaoc/.docker/cli-plugins/docker-scout

Server:
 Containers: 20
  Running: 5
  Paused: 0
  Stopped: 15
 Images: 141
 Server Version: 27.3.1
 Storage Driver: overlayfs
  driver-type: io.containerd.snapshotter.v1
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 472731909fa34bd7bc9c087e4c27943f9835f111
 runc version: v1.1.13-0-g58aa920
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.10.14-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 12
 Total Memory: 7.653GiB
 Name: docker-desktop
 ID: 275e806e-6b09-4a6a-86e4-db4fb710c1a6
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=unix:///Users/joaoc/Library/Containers/com.docker.docker/Data/docker-cli.sock
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: daemon is not using the default seccomp profile

Anything else?

No response

@ndeloof
Copy link
Contributor

ndeloof commented Nov 22, 2024

That's not a bug: stop respect dependencies and wait for all dependent containers to be stopped before stopping another one, so that they all stop gracefully and avoid data corruption or such things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants