-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upload wheel variants for CUDA 11 and 12 #10807
Comments
@jameslamb Can you review my proposal? I kept the |
@hcho3 let me start by saying I am SO SORRY it took over a month to get back to you! Thanks for redirecting me here from #10803. I've read this and the motivating issue (#10729) now. I support this proposal. I think the approach you've proposed is a good one... it minimizes disruption to existing users of I still think you should exploring modifying the
Thank you! This was what I was most worried about in #10803 (comment), I think because there you described "re-naming" the package, which I assumed meant that
I don't think that Instead, I'd package this as a wheel with only the minimum files required to be a valid wheel file, and with a dependency [project]
name = "xgboost-cu12"
version = "2.2.1"
dependencies = [
"xgboost==2.2.1"
] Benefits:
|
Currently, we build two wheel variants:
xgboost-cpu
(which excludes GPU code) andxgboost
(where the GPU code targets CUDA 12.4). In #10729,xgboost
is found to conflict with another package using CUDA 11.Following the practices of RAPIDS, we should distribute separate wheels targeting CUDA 11 and CUDA 12.
Proposal. Build four wheel variants.
xgboost-cpu
: excludes the GPU codexgboost-cu11
: builds GPU code with CUDA 11, depends onnvidia-nccl-cu11
.xgboost
: builds GPU code with CUDA 12, depends onnvidia-nccl-cu12
.xgboost-cu12
: a stub package directing users to installxgboost
. Something like https://pypi.org/project/cuml. The stub package can be replaced with a real one when the main packagexgboost
transitions to CUDA 13.Prerequisites
xgboost-cu11
to 200 MiB.sm_50
.rapids-dependency-file-generator
to generate pyproject.toml #10803The text was updated successfully, but these errors were encountered: