Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of enumer hurts code coverage metrics #66

Open
muir opened this issue Sep 6, 2022 · 1 comment
Open

Use of enumer hurts code coverage metrics #66

muir opened this issue Sep 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@muir
Copy link

muir commented Sep 6, 2022

In my project, I wrote a test to fully cover enumer-generated code.
I would be happy/willing to take that test and add a flag to enumer so that enumer will generate tests too.

Let me know.

See https://github.com/muir/xop-go/blob/main/internal/enumer_test.go

@dmarkham dmarkham added the enhancement New feature or request label Sep 28, 2022
@dmarkham
Copy link
Owner

dmarkham commented Nov 7, 2023

I appreciate the initiative to enhance enumer with test generation, and I see where you're coming from. However, I believe that the robustness of our tests comes from using the types as they are intended in real scenarios, rather than generating tests for the sake of coverage metrics. That being said, I'm not opposed to new ideas. If you've got a pull request, I'd be willing to review it and discuss the potential benefits it could bring to our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants