-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Unable to use keybindings on pull request without having the repo pulled down? #353
Comments
Seems simple to solve, care to contribute it? |
@dlvhdr I'd be happy to try. I'm relatively new to golang so I'll probably need a few pointers. My use case is I'd like to be able to use gh-dash to manage all open pull requests, irrespective of having a repo cloned down. As for the command I would like to run, I want to have a keyboard shortcut that let's me approve a PR. |
Lines 112 to 118 in 94c6603
@venkatamutyala Over-zealous error check here, I believe. Exits out early without actually knowing or caring if the template being Executed needs the local path. |
Removes an assumption that specific data/keys are required by the bound command. Instead `Template.Option()` is used to tell the Template to error out if and when it actually encounters a key it needs.
Unfortuneatly it seems the Template options are a little lacking, and I don't believe can be persuaded to accept zero values or even nil pointers as 'missing' values. The struct in question, `PRCommandTemplateInput`, appears to have no use elsewhere however, so was easily replaced with a map, which I hope serves your needs for the near future at least.
Removes an assumption that specific data/keys are required by the bound command. Instead `Template.Option()` is used to tell the Template to error out if and when it actually encounters a key it needs.
Unfortuneatly it seems the Template options are a little lacking, and I don't believe can be persuaded to accept zero values or even nil pointers as 'missing' values. The struct in question, `PRCommandTemplateInput`, appears to have no use elsewhere however, so was easily replaced with a map, which I hope serves your needs for the near future at least.
Describe the bug
Using custom keybindings to preform actions extermally
To Reproduce
Steps to reproduce the behavior:
keybindings:
issues: []
prs:
command: >
echo "Hello" > test.txt
and when the binding it says "Failed to find the local path for the repo ...
Expected behavior
I expected it to just echo "Hello" to disk. I didn't expect to have the actual repo cloned down in order to be able to run external commands.
Screenshots
N/A
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: