Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Typescript #186

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Updated Typescript #186

merged 2 commits into from
Oct 30, 2024

Conversation

Peeterush
Copy link
Contributor

update-index broke in 930167c because the old lock file uses v20.3.0 of @types/node. Generating a new lock file updates it to v22.8.2, resolving the issue.

package.json Outdated Show resolved Hide resolved
@dlemstra
Copy link
Owner

It looks like we are getting different errors now. And it looks like this is working in your environment because you are using node 22 right? I am still on 20 on my machine.

@Peeterush
Copy link
Contributor Author

Peeterush commented Oct 29, 2024

I'm currently looking into that yes. The errors can be ignored by adding a @ts-expect-error comment before each of the lines, but I'm wondering if TS is actually catching a bug here. Going by the error messages it seems that among others Channels.Meta0 is the exact same value as Channels.Meta32. Is that intentional?

Edit: I am on Node v20.18.0, these errors are a new typescript 5.6 feature: microsoft/TypeScript@1250b48

@dlemstra
Copy link
Owner

dlemstra commented Oct 29, 2024

WebAssembly is only 32 bit so those channels should be removed. I pushed a patch to remove this.

@dlemstra
Copy link
Owner

I also had to delete my node_modules folder to get the update to v22.8.2.

@dlemstra
Copy link
Owner

Just pushed a commit where I recreated the file with node 22.11.

@dlemstra dlemstra merged commit 1e9874d into dlemstra:main Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants