Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emplace doesn't warn about private constructors #10588

Open
jibal opened this issue Dec 13, 2024 · 1 comment
Open

emplace doesn't warn about private constructors #10588

jibal opened this issue Dec 13, 2024 · 1 comment

Comments

@jibal
Copy link
Contributor

jibal commented Dec 13, 2024

emplace could do a much better job of detecting the reasons for failure, but this seems like an obvious one
(though the check isn't entirely trivial because you have to find the right ctor and check its visibility)

@TurkeyMan
Copy link
Contributor

I wouldn't worry too much. emplace will be deleted soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants