Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem updating babel dependency #1597

Open
bmispelon opened this issue Jul 26, 2024 · 0 comments
Open

Problem updating babel dependency #1597

bmispelon opened this issue Jul 26, 2024 · 0 comments

Comments

@bmispelon
Copy link
Member

Looks like the migration check breaks when updating babel: #1593

I haven't had time to investigate, but it seems that upgrading babel triggers some changes in some models in the foundation app (from the CI failure in the PR linked above):

 Migrations for 'foundation':
  foundation/migrations/0005_alter_approvedgrant_amount_currency_and_more.py
    - Alter field amount_currency on approvedgrant
    - Alter field treasurer_balance_currency on meeting

We have a check that triggers a failure when such changes happen, which is why the PR has a red mark.

I don't have time to look at it right now, so if anyone wants to dig into the issue, they are most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant