Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify header text in community pages #1563

Open
bmispelon opened this issue Jun 27, 2024 · 4 comments · May be fixed by #1614
Open

Simplify header text in community pages #1563

bmispelon opened this issue Jun 27, 2024 · 4 comments · May be fixed by #1614
Assignees
Labels
good first issue Good for newcomers python Pull requests that update Python code

Comments

@bmispelon
Copy link
Member

Currently the header in the community pages looks like this:

Screenshot 2024-06-27 at 14-10-10 Django Community Django

The text "Building the Django Community for 18 years, 11 months. Come join us!" is a bit too detailed, and based on a comment in the code, it seems like it was intended to be shorter:

# Django 3.2 introduces depth kwarg. Set timesince(..., depth=1) then.

Ideally, the text should read "for 18 years", which would be done by using timesince(..., depth=1) as the comment linked above mentions. A test would also be needed (in the aggregator/tests.py file).

This could be a good first-time contribution, anyone should feel free to try and send a PR.

@bmispelon bmispelon added python Pull requests that update Python code good first issue Good for newcomers labels Jun 27, 2024
@rawasaditya
Copy link

I would like to do this please assign this issue to me
Thanks

@bmispelon
Copy link
Member Author

I would like to do this please assign this issue to me Thanks

Done ✅

For future reference, you don't need to be assigned to an issue to work on it. You can simply leave a comment on the ticket, that's enough to inform people that you're working on it, and to avoid two people working on the same ticket at the same time.

Lakshya272 added a commit to Lakshya272/djangoproject.com that referenced this issue Jun 30, 2024
Added the 'depth' keyword and set it to 1 to simplify header text in community pages

Issue resolved: Simplify header text in community pages django#1563
@Navyashreeamam
Copy link

Navyashreeamam commented Aug 21, 2024

from datetime import date
from django.utils.timesince import timesince

DJANGO_DOB = date(2005, 7, 14)

def community_stats(request):
"""
Context processor to calculate Django's age for the community pages.
"""
# Using depth=1 to show only years.
stats = {"age": timesince(DJANGO_DOB, depth=1)}
return {"community_stats": stats}
please assign this issue to me

WajahatKanju pushed a commit to WajahatKanju/djangoproject.com that referenced this issue Sep 1, 2024
@WajahatKanju
Copy link
Contributor

WajahatKanju commented Sep 1, 2024

@bmispelon I've submitted a PR to address the issue with simplifying the header text on the community pages. Please check out PR #1614 and let me know if any further adjustments are needed. Thanks!

image
To
image

WajahatKanju pushed a commit to WajahatKanju/djangoproject.com that referenced this issue Sep 1, 2024
WajahatKanju pushed a commit to WajahatKanju/djangoproject.com that referenced this issue Sep 1, 2024
@WajahatKanju WajahatKanju linked a pull request Sep 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants