-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use django-contact-form's builtin AkismetContactForm #1559
Comments
Sir, I would like to do this. Please assign the issue to me. |
Hi, I've assigned you, but for reference you don't need to be assigned to an issue to work on it. It's enough to write a comment, so that others know you're working on it. |
Hello! I'm too working on this issue. Here's my current plan:
I'll submit a pull request with these changes once I've implemented and tested them. If anyone has any suggestions or concerns, please let me know. I'm open to feedback and guidance, especially regarding maintaining compatibility with the rest of the project. Is there anything else I should consider before proceeding? |
#1584 Hi @bmispelon, Could you please review this PR when you have a moment. |
If the issue is still open, i would like to take it |
Hi and thanks for your interest. The issue is still open yes, but you can see from the history of this issue that there's already two people working on it, and one open pull request (which has some broken automated tests that need fixing). The best way forward would be to collaborate with the current contributors in order to fix the broken tests in the existing pull request. |
The
BaseContactForm
incontact/forms.py
has a customclean_body()
method that checks the message against the anti-spam service akismet. The docstring on that method seems to indicate that this method was copy/pasted from an old version of django-contact-form because the functionality was removed at some point.However, it seems the functionality is builtin to the current version of django-contact-form: https://django-contact-form.readthedocs.io/en/latest/forms.html#django_contact_form.forms.AkismetContactForm
So we should be able to remove and simplify our code by using it.
The text was updated successfully, but these errors were encountered: