Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile markup on a docs page #1488

Open
circus2271 opened this issue Mar 2, 2024 · 0 comments
Open

Improve mobile markup on a docs page #1488

circus2271 opened this issue Mar 2, 2024 · 0 comments

Comments

@circus2271
Copy link
Contributor

circus2271 commented Mar 2, 2024

second tap on mobile version-switcher doesn't necessarily close the menu

hover.mp4

this happens because of hover
(tap on button toggles "open" class, but there are also very similar styles which append on hover
so, if button already doesn't have "open" class, it may still be open due to hover styles)

the fix is to remove hover for mobile and turn it on only for desktops (width >= 1200px)

circus2271 added a commit to circus2271/djangoproject.com that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant