Skip to content

Commit 1856964

Browse files
Prevented EOL date from being set to "today" on alpha1 releases
1 parent 9a58df6 commit 1856964

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

releases/models.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,8 @@ def set_previous_release_as_eol(self):
318318
}
319319
if self.iteration > 1:
320320
previous_release_kwargs["iteration"] = self.iteration - 1
321+
elif self.status == "a":
322+
return
321323
elif self.status == "b":
322324
previous_release_kwargs["status"] = "a"
323325
elif self.status == "c":

releases/tests.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ def test_save_eol_date_pre_releases(self):
216216
other_release = Release.objects.create(version="5.1.7", is_active=True)
217217
today = datetime.date.today()
218218
cases = [
219+
("5.1.1", "5.2a1"),
219220
("5.2a1", "5.2a2"),
220221
("5.2a2", "5.2b1"),
221222
("5.2b1", "5.2rc1"),
@@ -229,10 +230,14 @@ def test_save_eol_date_pre_releases(self):
229230
is_active=True,
230231
)
231232
self.assertIsNone(previous_release.eol_date)
232-
Release.objects.create(version=next_version, is_active=True)
233+
next_release = Release.objects.create(
234+
version=next_version, is_active=True
235+
)
233236
previous_release.refresh_from_db()
234237
other_release.refresh_from_db()
235-
self.assertEqual(previous_release.eol_date, today)
238+
if next_release.version_tuple[-2:] != ("alpha", 1):
239+
self.assertEqual(previous_release.eol_date, today)
240+
self.assertIsNone(next_release.eol_date)
236241
self.assertIsNone(other_release.eol_date)
237242

238243

0 commit comments

Comments
 (0)