Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Organize Type System #37

Open
kamescg opened this issue Nov 27, 2024 · 0 comments
Open

Task: Organize Type System #37

kamescg opened this issue Nov 27, 2024 · 0 comments
Labels

Comments

@kamescg
Copy link
Contributor

kamescg commented Nov 27, 2024

Context

The Universal monorepo includes a considerable amount of data schemas, structures and mutations.

The types are spread across multiple apps and packages:

  • api-credentials
  • api-identity
  • api-delegations
  • api-universal
  • universal-credential-sdk
  • universal-data-sdk
  • universal-delegations-sdk
  • universal-identity-sdk

It's not sustainable and we need to start co-locating types in an singular package.

The universal-data package is not the right package for exporting common types like TokenItem, TokenList, SocialCredential, DelegationExecutions, DelegationWithMetadata, etc...

Scope

Create a new package packages/universal-types that is the canonical source for types across the monorepo.

It should import/export types database from the API services and also combine/merge types when appropriate (i.e. SocialCredential) so UI components can have assurances about what data is being passed around.

Moves types from the universal-data package to the universal-types package.

@kamescg kamescg added the task label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant