Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(data-modelling): Update currency field to hold a complete list of possible options in Financial.CurrencyConversions collection #40

Open
1 task
ll-zerr opened this issue Apr 11, 2024 · 0 comments
Open
1 task

Feat(data-modelling): Update currency field to hold a complete list of possible options in Financial.CurrencyConversions collection #40

ll-zerr opened this issue Apr 11, 2024 · 0 comments

Comments

@ll-zerr
Copy link
Contributor

ll-zerr commented Apr 11, 2024 •
edited
Loading

The currency field type in the Financial.CurrencyConversions collection currently holds only 7 options to select from. As more options may be added in the future, this list should be updated to include all possible currency options.

  • Update the currency list to include all possible options.

Reference: #33 (comment)
@ll-zerr ll-zerr changed the title **thought:** I think it does make the most sense to have this as an enum, and you have added all of the currencies that were currently in the spreadsheet, however it is likely in the future that there will be more currency types to be considered. I don't think there's anything to be done here right now, but maybe we should add a task to fill out the currencies list? Feat(data-modelling): Update currency field to hold a complete list of possible options in Financial.CurrencyConversions collection Apr 11, 2024
@ll-zerr ll-zerr mentioned this issue Apr 11, 2024
Merged
@thegrumpyenby thegrumpyenby moved this to Triage in DA Tech Aug 1, 2024
@thegrumpyenby thegrumpyenby moved this from Triage to Ready for Work in DA Tech Aug 1, 2024
@thegrumpyenby thegrumpyenby moved this from Ready for Work to Backlog in DA Tech Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DA Tech
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ll-zerr