Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-modelling): Update Product.SecondHand component to use a custom component #28

Open
3 tasks
TravisAlmey opened this issue Mar 14, 2024 · 2 comments

Comments

@TravisAlmey
Copy link
Contributor

TravisAlmey commented Mar 14, 2024

The secondHand component of Product.Item uses canBeUsed and priceAdjustment fields denoting whether it is valid for an item to be a used product, and if so what the value of the product should be adjusted to be. These fields are currently independent, however it does not make sense for an item to have a price adjustment if the item should be be values as a used item.

Therefore the priceAdjustment field should only be enabled when the canBeUsed field is set to true.

  • Change the secondHand component to be a custom component
  • Link the canBeUsed and priceAdjustment fields to have a dependency
  • Ensure the link from the Product.PriceAdjustment component to the product.item collection is maintained

Reference: #17 (comment)

@thegrumpyenby thegrumpyenby moved this to Ready for Work in DA Tech Aug 1, 2024
@thegrumpyenby thegrumpyenby moved this from Ready for Work to Triage in DA Tech Aug 1, 2024
@safwanyp
Copy link

Hey! Seems like a decent starting point for me. Can I take this up?
I will look into the steps and list them out, and maybe someone can make sure they're the correct steps to take 😄

@safwanyp
Copy link

Correct me if I'm wrong, but this looks like it's already done? I see a bunch of commits made right after the creation of this issue, that seem to do what is described here 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants