Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using jvm properties to simplify versioning logic #12

Open
Baccata opened this issue Nov 1, 2018 · 1 comment
Open

Using jvm properties to simplify versioning logic #12

Baccata opened this issue Nov 1, 2018 · 1 comment

Comments

@Baccata
Copy link

Baccata commented Nov 1, 2018

The versioning logic is currently a bit awkward, with the CI creating new branches/committing/pushing on its own for the sole purpose of versioning.

A simpler approach would be to use jvm properties in order to dynamically resolve the version using some logic around git describe.

You could imagine providing a build script which would essentially redirect the args it gets called with to mvn -Drevision={insert_dynamic_version}, making the version easily reproducible/inspectable locally.

@markglh
Copy link
Contributor

markglh commented Nov 1, 2018

+1 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants