Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Undefined Class Usage in SubNavigation #319

Open
martyanovandrey opened this issue Oct 22, 2024 · 0 comments
Open

Refactor Undefined Class Usage in SubNavigation #319

martyanovandrey opened this issue Oct 22, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@martyanovandrey
Copy link
Contributor

Problem

The SubNavigation component in diplodoc-platform/components uses the .dc-root_wide-format class, which isn't defined in the current library. This can cause styling issues.

image

Solution

Move the styles for .dc-root_wide-format from the diplodoc-platform/components package to the diplodoc-platform/client package.

Tasks

  1. Identify Usage: Find all occurrences of .dc-root_wide-format in SubNavigation.
  2. Move Styling: Transfer these styles to the client package.
  3. Update References: Modify any references in SubNavigation to use the relocated styles.
  4. Testing: Ensure the component works and is styled correctly post-changes.

Goal

Ensure SubNavigation maintains functionality and appearance with appropriately defined styles.

@martyanovandrey martyanovandrey added the good first issue Good for newcomers label Oct 22, 2024
@martyanovandrey martyanovandrey moved this to Todo in Help wanted Oct 22, 2024
@martyanovandrey martyanovandrey added enhancement New feature or request and removed enhancement New feature or request labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

1 participant