Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a benchmark test to compare PR performance against master #52

Open
cesco69 opened this issue Nov 11, 2024 · 2 comments
Open

feat: Add a benchmark test to compare PR performance against master #52

cesco69 opened this issue Nov 11, 2024 · 2 comments

Comments

@cesco69
Copy link
Contributor

cesco69 commented Nov 11, 2024

To improve performance and prevent potential slowdowns, it would be useful to introduce a test that benchmarks each Pull Request (PR) against the master branch. This benchmark test would help identify any performance regressions early on and ensure that new changes do not negatively impact the system’s efficiency.
@Pho3niX90
Copy link
Contributor

https://github.com/dimdenGD/ultimate-express/actions/workflows/benchmark.yml was recently introduced, however, it doesn't test against master. Could be altered

@cesco69
Copy link
Contributor Author

cesco69 commented Nov 12, 2024 •
edited
Loading

Side note: Express has just introduced a benchmark test against master for the PR

expressjs/express#6129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cesco69 @Pho3niX90