GetLogsink updated to handled unwrapped API response (#928)

do-joe · DO-rrao · web-flow · commit d3f4588e1220 · 2025-11-12T22:37:24.000+05:30
Co-authored-by: DO-rrao &lt;rrao@digitalocean.com&gt;
diff --git a/databases.go b/databases.go
@@ -2107,12 +2107,12 @@ func (svc *DatabasesServiceOp) GetLogsink(ctx context.Context, databaseID string
 		return nil, nil, err
 	}
 
-	root := new(databaseLogsinkRoot)
+	root := new(DatabaseLogsink)
 	resp, err := svc.client.Do(ctx, req, root)
 	if err != nil {
 		return nil, resp, err
 	}
-	return root.Sink, resp, nil
+	return root, resp, nil
 }
 
 // ListTopics returns all topics for a given kafka cluster
diff --git a/databases_test.go b/databases_test.go
@@ -4196,15 +4196,13 @@ func TestDatabases_GetLogsink(t *testing.T) {
 	}
 
 	body := `{
-        "sink": {
           "sink_id":"deadbeef-dead-4aa5-beef-deadbeef347d",
           "sink_name": "logs-sink",
           "sink_type": "opensearch",
           "config": {
             "url": "https://user:passwd@192.168.0.1:25060",
             "index_prefix": "opensearch-logs"
           }
-        }
       }`
 
 	path := fmt.Sprintf("/v2/databases/%s/logsink/%s", dbID, logsinkID)

Original file line number	Diff line number	Diff line change
`@@ -2107,12 +2107,12 @@ func (svc *DatabasesServiceOp) GetLogsink(ctx context.Context, databaseID string`
`2107`	`2107`	`return nil, nil, err`
`2108`	`2108`	`}`
`2109`	`2109`
`2110`		`- root := new(databaseLogsinkRoot)`
	`2110`	`+ root := new(DatabaseLogsink)`
`2111`	`2111`	`resp, err := svc.client.Do(ctx, req, root)`
`2112`	`2112`	`if err != nil {`
`2113`	`2113`	`return nil, resp, err`
`2114`	`2114`	`}`
`2115`		`- return root.Sink, resp, nil`
	`2115`	`+ return root, resp, nil`
`2116`	`2116`	`}`
`2117`	`2117`
`2118`	`2118`	`// ListTopics returns all topics for a given kafka cluster`
Original file line number	Diff line number	Diff line change
`@@ -4196,15 +4196,13 @@ func TestDatabases_GetLogsink(t *testing.T) {`
`4196`	`4196`	`}`
`4197`	`4197`
`4198`	`4198`	body := `{
`4199`		`- "sink": {`
`4200`	`4199`	`"sink_id":"deadbeef-dead-4aa5-beef-deadbeef347d",`
`4201`	`4200`	`"sink_name": "logs-sink",`
`4202`	`4201`	`"sink_type": "opensearch",`
`4203`	`4202`	`"config": {`
`4204`	`4203`	`"url": "https://user:[email protected]:25060",`
`4205`	`4204`	`"index_prefix": "opensearch-logs"`
`4206`	`4205`	`}`
`4207`		`- }`
`4208`	`4206`	}`
`4209`	`4207`
`4210`	`4208`	`path := fmt.Sprintf("/v2/databases/%s/logsink/%s", dbID, logsinkID)`