added provision for attach and detach share (#926)

* added provision for attach and detach share

* fixed comments

---------

Co-authored-by: anup-deka <[email protected]>

Author: niket-dujari

nfs_actions.go

@@ -12,6 +12,8 @@ import (
 type NfsActionsService interface {
 	Resize(ctx context.Context, nfsShareId string, size uint64, region string) (*NfsAction, *Response, error)
 	Snapshot(ctx context.Context, nfsShareId string, nfsSnapshotName string, region string) (*NfsAction, *Response, error)
+	Attach(ctx context.Context, nfsShareId string, vpcID string, region string) (*NfsAction, *Response, error)
+	Detach(ctx context.Context, nfsShareId string, vpcID string, region string) (*NfsAction, *Response, error)
 }
 
 // NfsActionsServiceOp handles communication with the NFS action related
@@ -57,6 +59,16 @@ type NfsSnapshotParams struct {
 	Name string `json:"name"`
 }
 
+// NfsAttachParams represents parameters for attaching an NFS share to a VPC
+type NfsAttachParams struct {
+	VpcID string `json:"vpc_id"`
+}
+
+// NfsDetachParams represents parameters for detaching an NFS share from a VPC
+type NfsDetachParams struct {
+	VpcID string `json:"vpc_id"`
+}
+
 // Resize an NFS share
 func (s *NfsActionsServiceOp) Resize(ctx context.Context, nfsShareId string, size uint64, region string) (*NfsAction, *Response, error) {
 	request := &NfsActionRequest{
@@ -83,6 +95,32 @@ func (s *NfsActionsServiceOp) Snapshot(ctx context.Context, nfsShareId, nfsSnaps
 	return s.doAction(ctx, nfsShareId, request)
 }
 
+// Attach an NFS share
+func (s *NfsActionsServiceOp) Attach(ctx context.Context, nfsShareId, vpcID, region string) (*NfsAction, *Response, error) {
+	request := &NfsActionRequest{
+		Type:   "attach",
+		Region: region,
+		Params: &NfsAttachParams{
+			VpcID: vpcID,
+		},
+	}
+
+	return s.doAction(ctx, nfsShareId, request)
+}
+
+// Detach an NFS share
+func (s *NfsActionsServiceOp) Detach(ctx context.Context, nfsShareId, vpcID, region string) (*NfsAction, *Response, error) {
+	request := &NfsActionRequest{
+		Type:   "detach",
+		Region: region,
+		Params: &NfsAttachParams{
+			VpcID: vpcID,
+		},
+	}
+
+	return s.doAction(ctx, nfsShareId, request)
+}
+
 func (s *NfsActionsServiceOp) doAction(ctx context.Context, nfsShareId string, request *NfsActionRequest) (*NfsAction, *Response, error) {
 	if request == nil {
 		return nil, nil, NewArgError("request", "request can't be nil")

nfs_actions_test.go

@@ -48,3 +48,43 @@ func TestNfsSnapshot(t *testing.T) {
 	assert.Equal(t, "in-progress", action.Status)
 	assert.Equal(t, "snapshot", action.Type)
 }
+
+func TestNfsAttach(t *testing.T) {
+	setup()
+	defer teardown()
+
+	mux.HandleFunc("/v2/nfs/my-nfs-id/actions", func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, http.MethodPost, r.Method)
+		w.WriteHeader(http.StatusCreated)
+		fmt.Fprint(w, `{"action": {"id": 1, "status": "in-progress", "type": "attach", "resource_type": "network_file_share", "resource_id": "my-nfs-id", "region_slug": "atl1", "started_at": "2025-10-14T11:55:31.615157397Z"}}`)
+	})
+
+	action, resp, err := client.NfsActions.Attach(context.Background(), "my-nfs-id", "my-vpc-id", "atl1")
+	assert.NoError(t, err)
+	assert.NotNil(t, resp)
+	assert.Equal(t, "my-nfs-id", action.ResourceID)
+	assert.Equal(t, "atl1", action.RegionSlug)
+	assert.Equal(t, "network_file_share", action.ResourceType)
+	assert.Equal(t, "in-progress", action.Status)
+	assert.Equal(t, "attach", action.Type)
+}
+
+func TestNfsDetach(t *testing.T) {
+	setup()
+	defer teardown()
+
+	mux.HandleFunc("/v2/nfs/my-nfs-id/actions", func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, http.MethodPost, r.Method)
+		w.WriteHeader(http.StatusCreated)
+		fmt.Fprint(w, `{"action": {"id": 1, "status": "in-progress", "type": "detach", "resource_type": "network_file_share", "resource_id": "my-nfs-id", "region_slug": "atl1", "started_at": "2025-10-14T11:55:31.615157397Z"}}`)
+	})
+
+	action, resp, err := client.NfsActions.Detach(context.Background(), "my-nfs-id", "my-vpc-id", "atl1")
+	assert.NoError(t, err)
+	assert.NotNil(t, resp)
+	assert.Equal(t, "my-nfs-id", action.ResourceID)
+	assert.Equal(t, "atl1", action.RegionSlug)
+	assert.Equal(t, "network_file_share", action.ResourceType)
+	assert.Equal(t, "in-progress", action.Status)
+	assert.Equal(t, "detach", action.Type)
+}