Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransmissionId should only be allowed on activity type TransmissionOpened #1630

Open
oskogstad opened this issue Dec 23, 2024 · 0 comments
Open

TransmissionId should only be allowed on activity type TransmissionOpened #1630

oskogstad opened this issue Dec 23, 2024 · 0 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Description

The validator activity validator allows setting TransmissionId on every activity type except DialogOpened.
It should only allow on TransmissionOpened.

Reproduction

Create an activity, f.ex. of type DialogCreated, and set transmissionId to a valid UUID (ie, a transmission on the dialog)

Expected behavior

400 BAD REQUEST saying transmissionId is not allowed for this activity type

Actual behavior

201 CREATED
@oskogstad oskogstad added the bug Something isn't working label Dec 23, 2024
@oskogstad oskogstad moved this to Code Review og PR in Dialogporten / Arbeidsflate Dec 23, 2024
@oskogstad oskogstad self-assigned this Dec 23, 2024
@oskogstad oskogstad mentioned this issue Dec 23, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Dec 23, 2024
@oskogstad
fix(webapi): Only allow transmissionId on TransmissionOpened activiti…
80261d1 
…es (#1631)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->
The validator activity validator allows setting TransmissionId on every
activity type except DialogOpened.
It should only allow on TransmissionOpened.

## Related Issue(s)

- #1630 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Code Review og PR
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oskogstad