Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET sub-resources on deleted dialogs returns 404 #1563

Open
oskogstad opened this issue Dec 6, 2024 · 2 comments
Open

GET sub-resources on deleted dialogs returns 404 #1563

oskogstad opened this issue Dec 6, 2024 · 2 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Description

GET on sub-resources when the dialog is softly deleted returns 404 NOT FOUND

Reproduction

Create a dialog, then soft-delete it.
Call f.ex. GET /api/v1/serviceowner/dialogs/:dialogId/activities

Expected behavior

410 GONE

Actual behavior

404 NOT FOUND
@oskogstad oskogstad added the bug Something isn't working label Dec 6, 2024
@oskogstad oskogstad moved this to Code Review og PR in Dialogporten / Arbeidsflate Dec 6, 2024
@oskogstad oskogstad self-assigned this Dec 6, 2024
@oskogstad oskogstad mentioned this issue Dec 6, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Dec 6, 2024
@oskogstad
fix(webapi): Return 410 GONE for sub-resources on soft-deleted dialogs (
bb601a9 
#1564)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1563

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@oskogstad oskogstad moved this from Code Review og PR to Testing in Dialogporten / Arbeidsflate Dec 7, 2024
@LeifHelstad
Copy link

Har testet denne via #1541, se notater fra kjøringen der. De er duplikater og begge forventet 410 Gone. Testen gir 400 Bad Request. Setter teststatus til Failed.

@LeifHelstad
Copy link

Nå er #1541 lukket etter vellykket test. Denne #1563 er i praksis en duplikat. Lukker også den med test Passed.

Årsak til at testene ikke fikk forventet resultat fredag 13.desember ser ut til å være relatert til deplymentproblemer i staging miljø.
https://github.com/digdir/dialogporten/deployments/staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskogstad @LeifHelstad