-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Azure Monitor Workspace in our IAC #1462
Labels
monitoring
Issue related to logging and monitoring
Comments
4 tasks
arealmaas
added a commit
that referenced
this issue
Nov 19, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Adds an azure monitor workspace which will enable us to send metrics to Prometheus ## Related Issue(s) - #1462 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a monitoring workspace module for enhanced resource monitoring capabilities. - Added a dedicated network security group and subnet for monitoring purposes. - **Bug Fixes** - Improved network configuration without affecting existing setups for other components. - **Documentation** - Updated output sections to include new identifiers for monitoring resources. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
4 tasks
arealmaas
added a commit
that referenced
this issue
Nov 19, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Struggling with connecting to the monitor workspace. Enabling public access and removing the private dns for now. #1462 ## Related Issue(s) - #{issue number} ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled public network access for the monitoring workspace, allowing for improved connectivity. - **Bug Fixes** - Adjusted the configuration to ensure a reliable connection to the monitor workspace. - **Chores** - Removed parameters related to private networking (`subnetId` and `vnetId`) from the deployment configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
export the workspace id, so we can use that when configuring the container app enviroment.
Tasks
The text was updated successfully, but these errors were encountered: