-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update pull_request_template.md #1382
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new section titled "Related Issue(s)" in the pull request template located in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/pull_request_template.md (2)
6-9
: Consider enhancing the Related Issues sectionWhile adding issue tracking is valuable, consider these improvements:
- Maintain language consistency by using Norwegian ("Relaterte saker")
- Add guidance for multiple issues
- Include brief usage instructions
-## Related Issue(s) - -#{issue number} +## Relaterte saker +<!--- Legg til issue-nummer som denne PR-en løser eller er relatert til. Fjern denne linjen hvis ingen issues er relevante. --> +- #{issue-nummer} +<!-- For flere issues, legg til flere linjer -->
Line range hint
1-18
: Consider enhancing template with additional guidanceThe template structure is solid, but consider these enhancements to improve PR quality:
- Add a section for breaking changes
- Include a reviewer checklist
- Add links to relevant documentation (e.g., coding standards, test guidelines)
Example additions:
## Breaking Changes <!--- Hvis endringene dine inneholder breaking changes, beskriv dem her og hvordan andre utviklere bør håndtere dem --> ## For Reviewers <!--- Sjekkliste for reviewers --> - [ ] Koden følger våre kodestandarder - [ ] Endringene er godt dokumentert - [ ] Testene er dekkende ## Nyttige Lenker - [Kodestandarder](link-to-standards) - [Testveiledning](link-to-test-guidelines)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/pull_request_template.md
(2 hunks)
🔇 Additional comments (1)
.github/pull_request_template.md (1)
18-18
: LGTM!
The newline addition ensures consistent rendering across platforms.
Hva er endret?
Dokumentasjon / Storybook / testdekning
stories
iStorybook
, eller så er ikke dette relevant.Skjermbilder eller GIFs (valgfritt)
Summary by CodeRabbit
New Features
Style