Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review React props again to make sure they are consistent #2902

Open
mimarz opened this issue Dec 16, 2024 · 0 comments
Open

Review React props again to make sure they are consistent #2902

mimarz opened this issue Dec 16, 2024 · 0 comments
Labels
react @digdir/designsystemet-react
Milestone
V1 - Must-have

Comments

@mimarz
Copy link
Collaborator

mimarz commented Dec 16, 2024 •
edited
Loading

Review React props again to make sure they are consistent across components.

Found some inconsistencies when testing our React components.

  • Textfield uses error prop as message passed to <ValidationMessage>, while Radio & Checkbox uses validationMessage prop for the same behaviour.
@mimarz mimarz converted this from a draft issue Dec 16, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Dec 16, 2024
@mimarz mimarz changed the title Check consistent React props again Review React props again to make sure they are consistent Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react @digdir/designsystemet-react
Projects
Team Design System
Status: 🔵 Inbox
Milestone
V1 - Must-have
Development

No branches or pull requests
2 participants
@mimarz @mrosvik