Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename theme, theme2, etc to actual brand names #2885

Open
unekinn opened this issue Dec 11, 2024 · 2 comments
Open

Rename theme, theme2, etc to actual brand names #2885

unekinn opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
✋ on hold $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme

Comments

@unekinn
Copy link
Contributor

unekinn commented Dec 11, 2024

In the internal design tokens, the brand-specific tokens are in files called theme.json, theme2.json etc instead of digdir.json, altinn.json etc. Similarly, the token paths are theme.accent..., theme2.accent... instead of digdir.accent..., altinn.accent.... This is very confusing.

@mimarz
Copy link
Collaborator

mimarz commented Dec 12, 2024

Is this ok to rename? @Febakke

This change will affect the update:template script in the cli, but we can just make sure to pick the digdir theme for that.

@mrosvik
Copy link
Member

mrosvik commented Dec 16, 2024

@Febakke Onhold until #2674 and #2728 is done.

@mrosvik mrosvik added ✋ on hold $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme labels Dec 16, 2024
@mrosvik mrosvik moved this from 🔵 Inbox to 📄 Todo in Team Design System Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ on hold $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme
Projects
Status: 📄 Todo
Development

No branches or pull requests

4 participants