Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Suggestion): ✨ new component #2881

Draft
wants to merge 17 commits into
base: next
Choose a base branch
from
Draft

feat(Suggestion): ✨ new component #2881

wants to merge 17 commits into from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Dec 11, 2024 •
edited
Loading

#2832 #2610
resolves #2882

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4dfdb34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 16. Dec 2024 - 12:02

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.55% 3223 / 5908
🔵 Statements 54.55% 3223 / 5908
🔵 Functions 83.79% 181 / 216
🔵 Branches 77.19% 518 / 671
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Suggestion/Suggestion.tsx 29.16% 100% 0% 29.16% 46-155
packages/react/src/components/Suggestion/SuggestionClear.tsx 13.95% 100% 0% 13.95% 18-55, 62-77
packages/react/src/components/Suggestion/SuggestionEmpty.tsx 35.71% 100% 0% 35.71% 9-18
packages/react/src/components/Suggestion/SuggestionInput.tsx 37.5% 100% 0% 37.5% 12-24
packages/react/src/components/Suggestion/SuggestionList.tsx 33.33% 100% 0% 33.33% 15-31
packages/react/src/components/Suggestion/SuggestionOption.tsx 41.66% 100% 0% 41.66% 12-19
Generated in workflow #1301 for commit 4dfdb34 by the Vitest Coverage Report Action

@mimarz
Copy link
Collaborator

mimarz commented Dec 18, 2024 •
edited
Loading

I like the component api. Had a brief look at the code looks ok, some of it still seems WIP, but we can still tweak it.

I suggest we just add the EXPERIMENTAL_ prefix for the component name and a changeset for "new experimental component", so we can get it released and tested downstream. This is such a opinonated component and its easiest to get opinions and test it out in existing apps.

@Barsnes
Copy link
Member Author

Barsnes commented Dec 20, 2024

Should we care about this?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz Awaiting requested review from mimarz mimarz will be requested when the pull request is marked ready for review mimarz is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker will be requested when the pull request is marked ready for review eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn unekinn will be requested when the pull request is marked ready for review unekinn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Team Design System
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create single mode combobox named Suggestion
3 participants
@Barsnes @mimarz @eirikbacker