Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White surfaces on components #2845

Open
Thunear opened this issue Nov 28, 2024 · 1 comment · May be fixed by #2911
Open

White surfaces on components #2845

Thunear opened this issue Nov 28, 2024 · 1 comment · May be fixed by #2911
Assignees
Labels
🕵️ investigate Needs investigation

Comments

@Thunear
Copy link
Collaborator

Thunear commented Nov 28, 2024

We need white surfaces on our components. Using background-default for this does not fit the pattern and introduces issues when we try to create logic for surfaces.

  • Test neutral colors with alpha
  • Test alpha blending and WCAG contrasts
@Thunear Thunear converted this from a draft issue Nov 28, 2024
@Thunear Thunear self-assigned this Nov 28, 2024
@Thunear Thunear added the 🕵️ investigate Needs investigation label Nov 28, 2024
@Thunear Thunear changed the title Investigate how to achieve a white surface-default White surfaces on components Nov 28, 2024
@Thunear Thunear moved this from 🏗 In progress to 📄 Todo in Team Design System Dec 5, 2024
@mimarz mimarz added this to the V1 - Helhetlig tematisering milestone Dec 11, 2024
@Thunear Thunear moved this from 📄 Todo to 🏗 In progress in Team Design System Dec 13, 2024
@Thunear
Copy link
Collaborator Author

Thunear commented Dec 18, 2024

Meeting 17/12: @mimarz @mrosvik @Febakke @Thunear @eirikbacker + 2 extra members from Mattilsynet

  • We decided on making Surface Default in light mode white, and make the transition to Surface hover- and active states less noticeable. This way the grey color will work better on colored backgrounds.
  • For neutral in dark mode we decided on using alpha values. This might work better since surfaces are never completely black.
  • If the user wants grey surfaces, this color has to be added manually.

I will test this new approach and call for a new meeting a bit later.

@mimarz mimarz linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️ investigate Needs investigation
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

3 participants