Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support configuring jackson JsonParser. Feature #2272

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

support configuring jackson JsonParser. Feature #2272

wants to merge 2 commits into from
+88 −0

Conversation

rmanibus
Copy link

Fix #2271

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@rmanibus
Copy link
Author

rmanibus commented Sep 27, 2024 •
edited
Loading

sounds good ! on more thing,
I am wondering if enabling this specific feature ALLOW_COMMENTS would not have for result to effectively swallow the comment. This will allow jackson to read the json with the comment, but the pretty print would likely not contains the comment anymore.

@nedtwigg
Copy link
Member

I am wondering if enabling this specific feature ALLOW_COMMENTS would not have for result to effectively swallow the comment

Add a test to find out!

To merge this, I need

  • a test showing that it does what you want
  • update changelogs
  • update docs

@rmanibus
Copy link
Author

I took some time to test this and the comments indeed are getting swallowed.
But at least formatting is not failing anymore which is already an improvement ...

I don't think we can have a better result with jackson since comments are simply not part of the java representation.

@nedtwigg
Copy link
Member

Needs spotlessApply and changelog entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg nedtwigg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuring jackson JsonParser. Feature ALLOW_COMMENTS
2 participants
@rmanibus @nedtwigg