Edit Page without Commit - 2nd PR for Cleaner Diff #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting 1.5a3 - goal is to allow install of uncommitted file (the file you are currently editing) -copy paste from yajd commit #61: yajd@1812470
-Copy paste of yajd commit #62 (https://github.com/yajd/GitHubExtIns/blob/0a677ff88f1a361ded052beb068016be462a1c95/bootstrap.js) -Cut out the extraneous code running when adding button to editable page -Cleaned for PullRequest (PR)
bootstrap.js * Implemented discussion from here: https://github.com/diegocr/GitHubExtIns/pull/10/files * Did not address the using repeated code block
bootstrap.js * Forgot to mention that in previous commit, in the top comment block I added all the contributors install.rdf * Up revved to 1.5a3 * Increase max FF version to 31.* as thats what I tested it in * Added myself to the contributor tag * Added emails for Jerone and Zulkarnain K. and myself to match with diego
github made a chance so had to change selector to get form properly, this here is untested but it should work
made it so it avoids the triple `doc.querySelector('.js-blob-form)`. now only does it once and holds it in `myElseIfVar`. see here for more reasoning: http://stackoverflow.com/a/26943768/1828637
GitHub changed their selectors a bit on the filename, so added old and new way, in case they revert
github changed their site, so add button wasnt working on main page. this fixes it
trying out @jerone's recommendation of changing minibutton to btn.btn-sm from here: https://github.com/diegocr/GitHubExtIns/pull/10/files#r27792537
Removed console.log messages that I accidentally left in
Settings are with respect to the existing code;
|
Oh! No sorries please that was on me! I would love to but I'm not sure it will be accepted, I'm working on landing some important stuff right now (OS.File.Watcher bug and Profilist) so don't have time right now. :( Ideally I want to re-write the whole thing but async but I don't have the time right now. :( |
GitHub changed their editor id or something, this should fix that
typo fixed. textContents changed to textContent
ok before i was getting just what was scrolled in view code. now it gets full code
Fix for GitHub change to editor, without this, clicking the "Install with Uncommitted File" would fail and remain disabled.
Updated rev number to latest rev on AMO +001 due to @yajd fix for install uncommitted file.
|
@yajd update for fixing Githubs change to the edit page. They changed the id on the contenteditable. Back in working order for installing uncommitted files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as previous PR just cleaner diff. Thanks jerone for idea.