Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Swagger updates wallet/jws #818

Merged
merged 31 commits into from
Nov 21, 2024
Merged

📝 Swagger updates wallet/jws #818

merged 31 commits into from
Nov 21, 2024

Conversation

cl0ete
Copy link
Collaborator

@cl0ete cl0ete commented May 24, 2024

Updated docstrings

added unit tests

@cl0ete cl0ete added the documentation Improvements or additions to documentation label May 24, 2024
@cl0ete cl0ete self-assigned this May 24, 2024
@cl0ete cl0ete changed the title WIP: Swagger updates wallet/jws Swagger updates wallet/jws May 28, 2024
@cl0ete cl0ete marked this pull request as ready for review May 30, 2024 14:28
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
app/routes
   definitions.py20410648%107–189, 197–216, 261–350, 391–392, 450–466, 481–487, 508–517, 540–541, 558–560, 616–677, 721–722
   issuer.py1733878%95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
   jsonld.py604722%23–93, 104–137
   messaging.py241154%32–41, 61–71
   oob.py462839%27–68, 79–92, 116–127
   verifier.py1473378%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py762271%28–37, 56–57, 79–80, 92–99, 107–115
   jws.py422736%56–81, 113–136
   sd_jws.py422736%65–90, 121–144
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py1321291%314–318, 346, 356–361, 394–398, 426–431
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 197–198
   acapy_issuer_v2.py1012278%60–63, 87–127, 173, 219–220, 247
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_jsonld.py591673%134–169
   test_tenants.py3491596%186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
   test_wallet_credentials.py30197%55
   test_wallet_dids.py691086%93–108
app/tests/e2e/issuer
   test_save_exchange_record.py72199%177
app/tests/e2e/verifier
   test_proof_revoked_credential.py461274%142–215
   test_verifier.py2311295%683–756
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1203769%176, 271–352, 365–437
   definitions.py662661%29–50, 64–65, 94–124, 143–144
   member_acapy_clients.py36489%47–50, 73–74
   member_connections.py43881%80–91, 130–141
   member_wallets.py611575%29–34, 49–54, 69–74, 89–94, 111–118
app/tests/services
   test_revocation_registry.py135299%73, 104
app/tests/services/issuer
   test_issuer.py160299%335–339
app/tests/util
   connections.py862769%114–139, 148–165, 182–191, 246–263
   ledger.py501080%35, 43, 55, 63–67, 77, 83
   regression_testing.py351751%33, 41–68, 74–81
   sse_listener.py41880%50–55, 79–84
   trust_registry.py29390%24, 27–28
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   credentials.py13469%6, 11, 18, 21
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL13294103992% 

Tests Skipped Failures Errors Time
892 10 💤 0 ❌ 0 🔥 9m 21s ⏱️

@cl0ete cl0ete requested a review from ff137 June 4, 2024 07:48
Copy link

github-actions bot commented Jun 7, 2024

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app/models
   jws.py34197%42
app/routes
   definitions.py20410648%107–189, 197–216, 261–350, 391–392, 450–466, 481–487, 508–517, 540–541, 558–560, 616–677, 721–722
   issuer.py1733878%95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   verifier.py1473378%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py762271%28–37, 56–57, 79–80, 92–99, 107–115
   jws.py422736%66–91, 133–156
   sd_jws.py422736%65–90, 121–144
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py1321291%314–318, 346, 356–361, 394–398, 426–431
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 197–198
   acapy_issuer_v2.py1012278%60–63, 87–127, 173, 219–220, 247
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_jsonld.py591673%134–169
   test_tenants.py3491596%186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
   test_wallet_credentials.py30197%55
   test_wallet_dids.py691086%93–108
   test_wallet_jws.py40198%56
   test_wallet_sd_jws.py40198%56
app/tests/e2e/issuer
   test_save_exchange_record.py72199%177
app/tests/e2e/verifier
   test_proof_revoked_credential.py461274%142–215
   test_verifier.py2311295%692–765
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1203769%176, 271–352, 365–437
   definitions.py662661%29–50, 64–65, 94–124, 143–144
   member_acapy_clients.py36489%47–50, 73–74
   member_connections.py43881%80–91, 130–141
   member_wallets.py611575%29–34, 49–54, 69–74, 89–94, 111–118
app/tests/services
   test_revocation_registry.py135299%73, 104
app/tests/services/issuer
   test_issuer.py160299%335–339
app/tests/util
   connections.py862769%114–139, 148–165, 182–191, 246–263
   ledger.py501080%35, 43, 55, 63–67, 77, 83
   regression_testing.py351751%33, 41–68, 74–81
   sse_listener.py41880%50–55, 79–84
   trust_registry.py29390%24, 27–28
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   credentials.py13469%6, 11, 18, 21
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL13303104292% 

Tests Skipped Failures Errors Time
892 10 💤 0 ❌ 0 🔥 9m 29s ⏱️

Copy link

github-actions bot commented Jun 7, 2024

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app/models
   jws.py34197%42
app/routes
   definitions.py20414031%88–220, 274–283, 321–322, 334–343, 348, 380–396, 434–578, 663–664, 675, 707–742
   issuer.py1733878%95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   verifier.py1473378%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py763751%28–37, 56–57, 79–80, 92–99, 107–115, 124–133, 145–166
   jws.py422736%66–91, 133–156
   sd_jws.py422736%65–90, 121–144
app/services
   acapy_ledger.py611969%43–49, 79, 110–111, 124–140, 146–149, 196–197
   acapy_wallet.py401270%49–64, 98–99
   revocation_registry.py1322383%314–318, 346, 356–361, 394–398, 416–431, 437–445
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 197–198
   acapy_issuer_v2.py1012278%60–63, 87–127, 173, 219–220, 247
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_definitions.py795135%33–56, 68–80, 92–106, 118–146, 164–209
   test_jsonld.py591673%134–169
   test_revocation.py956334%27–76, 88–106, 117–143, 155–180, 192–206, 218–255, 266–292
   test_tenants.py34929615%27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
   test_wallet_dids.py691578%93–108, 120–131
   test_wallet_jws.py40198%56
   test_wallet_sd_jws.py40198%56
app/tests/e2e/issuer
   test_save_exchange_record.py72199%177
app/tests/e2e/verifier
   test_proof_revoked_credential.py461274%40–128
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1205653%132–207, 216–224, 234–256, 290–350, 385–435
   definitions.py661085%41–48, 57–63, 114–121, 134–139
   member_acapy_clients.py36489%47–50, 73–74
   member_async_clients.py50296%32–33
   member_connections.py43491%73, 91, 123, 141
   member_wallets.py611575%23–27, 43–47, 63–67, 83–87, 103–109
app/tests/services
   test_revocation_registry.py135299%73, 104
app/tests/services/issuer
   test_issuer.py160299%335–339
app/tests/util
   connections.py861780%164–165, 179, 191, 201–233, 262–263
   ledger.py502648%34–59, 63–67, 73–86
   regression_testing.py35974%33, 60–68, 74–81
   sse_listener.py41880%50–55, 79–84
   tenants.py241250%10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
   trust_registry.py29776%20–28
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   credentials.py13469%6, 11, 18, 21
   retry_method.py363017%15–36, 68–114
   string.py15193%24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL13303153588% 

Tests Skipped Failures Errors Time
892 39 💤 0 ❌ 0 🔥 3m 28s ⏱️

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app/models
   jws.py34197%42
app/routes
   definitions.py20410648%107–189, 197–216, 261–350, 391–392, 450–466, 481–487, 508–517, 540–541, 558–560, 616–677, 721–722
   issuer.py1733878%95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   verifier.py1473378%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py762271%28–37, 56–57, 79–80, 92–99, 107–115
   jws.py422736%97–122, 164–187
   sd_jws.py422736%134–159, 198–221
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py1321291%314–318, 346, 356–361, 394–398, 426–431
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 197–198
   acapy_issuer_v2.py1012278%60–63, 87–127, 173, 219–220, 247
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_jsonld.py591673%134–169
   test_tenants.py3491596%186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
   test_wallet_credentials.py30197%55
   test_wallet_dids.py691086%93–108
   test_wallet_jws.py40198%56
   test_wallet_sd_jws.py40198%56
app/tests/e2e/issuer
   test_save_exchange_record.py72199%177
app/tests/e2e/verifier
   test_proof_revoked_credential.py461274%142–215
   test_verifier.py2311295%692–765
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1203769%176, 271–352, 365–437
   definitions.py662661%29–50, 64–65, 94–124, 143–144
   member_acapy_clients.py36489%47–50, 73–74
   member_connections.py43881%80–91, 130–141
   member_wallets.py611575%29–34, 49–54, 69–74, 89–94, 111–118
app/tests/services
   test_revocation_registry.py135299%73, 104
app/tests/services/issuer
   test_issuer.py160299%335–339
app/tests/util
   connections.py862769%114–139, 148–165, 182–191, 246–263
   ledger.py501080%35, 43, 55, 63–67, 77, 83
   regression_testing.py351751%33, 41–68, 74–81
   sse_listener.py41880%50–55, 79–84
   trust_registry.py29390%24, 27–28
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   credentials.py13469%6, 11, 18, 21
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL13337104292% 

Tests Skipped Failures Errors Time
900 10 💤 0 ❌ 0 🔥 11m 30s ⏱️

Copy link

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app/models
   jws.py34197%42
app/routes
   definitions.py20414031%88–220, 274–283, 321–322, 334–343, 348, 380–396, 434–578, 663–664, 675, 707–742
   issuer.py1733878%95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   oob.py462839%58–99, 131–144, 170–181
   verifier.py1473378%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py763751%28–37, 56–57, 79–80, 92–99, 107–115, 124–133, 145–166
   jws.py422736%97–122, 164–187
   sd_jws.py422736%134–159, 198–221
app/services
   acapy_ledger.py611969%43–49, 79, 110–111, 124–140, 146–149, 196–197
   acapy_wallet.py401270%49–64, 98–99
   revocation_registry.py1322383%314–318, 346, 356–361, 394–398, 416–431, 437–445
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py871484%36, 76–110, 197–198
   acapy_issuer_v2.py1012278%60–63, 87–127, 173, 219–220, 247
app/services/onboarding
   tenants.py594524%30–98, 108–138
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py724044%28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%46–54
   test_definitions.py795135%33–56, 68–80, 92–106, 118–146, 164–209
   test_jsonld.py591673%134–169
   test_revocation.py956334%27–76, 88–106, 117–143, 155–180, 192–206, 218–255, 266–292
   test_tenants.py34929615%27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
   test_wallet_dids.py691578%93–108, 120–131
   test_wallet_jws.py40198%56
   test_wallet_sd_jws.py40198%56
app/tests/e2e/issuer
   test_save_exchange_record.py72199%177
app/tests/e2e/verifier
   test_proof_revoked_credential.py461274%40–128
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/fixtures
   credentials.py1205653%132–207, 216–224, 234–256, 290–350, 385–435
   definitions.py661085%41–48, 57–63, 114–121, 134–139
   member_acapy_clients.py36489%47–50, 73–74
   member_async_clients.py50296%32–33
   member_connections.py43491%73, 91, 123, 141
   member_wallets.py611575%23–27, 43–47, 63–67, 83–87, 103–109
app/tests/services
   test_revocation_registry.py135299%73, 104
app/tests/services/issuer
   test_issuer.py160299%335–339
app/tests/util
   connections.py861780%164–165, 179, 191, 201–233, 262–263
   ledger.py502648%34–59, 63–67, 73–86
   regression_testing.py35974%33, 60–68, 74–81
   sse_listener.py41880%50–55, 79–84
   tenants.py241250%10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
   trust_registry.py29776%20–28
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 191–195, 272
   credentials.py13469%6, 11, 18, 21
   retry_method.py363017%15–36, 68–114
   string.py15193%24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
webhooks/models
   conversions.py63690%70, 83, 91, 112, 149, 168
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL13337153588% 

Tests Skipped Failures Errors Time
900 39 💤 0 ❌ 0 🔥 4m 19s ⏱️

@cl0ete cl0ete marked this pull request as draft June 18, 2024 13:27
@ff137 ff137 changed the title Swagger updates wallet/jws 📝 Swagger updates wallet/jws Jul 24, 2024
@cl0ete cl0ete force-pushed the swagger-updates-wallet-jws branch 2 times, most recently from 2acb0a6 to 587041c Compare November 5, 2024 06:37
@cl0ete cl0ete marked this pull request as ready for review November 5, 2024 06:37
Copy link
Collaborator

@ff137 ff137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this tentatively -- after I've made a bunch of changes to the docstrings, optimising on readability (thanks to claude / GPT).

Since it was mostly written by GPT, and a lot of text being replaced, it's important to review.

@cl0ete please compare these latest commits with what you had previously, and see if there's any relevant details being omitted. Also, please ensure the new formatting renders properly on the swagger/scalar docs (like multiline bullet points, headings, etc). If you're happy with it, then it's good to merge! 🎉

And great stuff on the 100% unit test coverage, love seeing that 😄

@cl0ete cl0ete merged commit e587130 into master Nov 21, 2024
45 of 46 checks passed
@cl0ete cl0ete deleted the swagger-updates-wallet-jws branch November 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants