Skip to content

Commit b13d822

Browse files
committed
Include Sizzle and Qunit with bower. Fixes #14118.
1 parent c93f91e commit b13d822

File tree

9 files changed

+29
-82
lines changed

9 files changed

+29
-82
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ dist/.destination.json
1212
dist/.sizecache.json
1313
build/.sizecache.json
1414
node_modules
15+
bower_components

.gitmodules

Lines changed: 0 additions & 6 deletions
This file was deleted.

Gruntfile.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module.exports = function( grunt ) {
3838
selector: {
3939
destFile: "src/selector-sizzle.js",
4040
apiFile: "src/sizzle-jquery.js",
41-
srcFile: "src/sizzle/dist/sizzle.js"
41+
srcFile: "bower_components/sizzle/dist/sizzle.js"
4242
},
4343
build: {
4444
all: {
@@ -584,13 +584,12 @@ module.exports = function( grunt ) {
584584
// Load grunt tasks from NPM packages
585585
grunt.loadNpmTasks("grunt-compare-size");
586586
grunt.loadNpmTasks("grunt-git-authors");
587-
grunt.loadNpmTasks("grunt-update-submodules");
588587
grunt.loadNpmTasks("grunt-contrib-watch");
589588
grunt.loadNpmTasks("grunt-contrib-jshint");
590589
grunt.loadNpmTasks("grunt-contrib-uglify");
591590

592591
// Default grunt
593-
grunt.registerTask( "default", [ "update_submodules", "selector", "build:*:*", "jshint", "pre-uglify", "uglify", "post-uglify", "dist:*", "compare_size" ] );
592+
grunt.registerTask( "default", [ "selector", "build:*:*", "jshint", "pre-uglify", "uglify", "post-uglify", "dist:*", "compare_size" ] );
594593

595594
// Short list as a high frequency watch task
596595
grunt.registerTask( "dev", [ "selector", "build:*:*", "jshint" ] );

README.md

Lines changed: 2 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,10 @@ To create a custom build of the latest stable version, first check out the versi
9797
git pull; git checkout $(git describe --abbrev=0 --tags)
9898
```
9999

100-
Then, make sure all Node dependencies are installed and all Git submodules are checked out:
100+
Then, make sure all Node dependencies are installed:
101101

102102
```bash
103-
npm install && grunt
103+
npm install
104104
```
105105

106106
Create the custom build, use the `grunt custom` option, listing the modules to be excluded. Examples:
@@ -173,72 +173,11 @@ Additionally, both methods can be combined.
173173

174174

175175

176-
Updating Submodules
177-
-------------------
178-
179-
Update the submodules to what is probably the latest upstream code.
180-
181-
```bash
182-
grunt update_submodules
183-
```
184-
185-
Note: This task will also be run any time the default `grunt` command is used.
186-
187-
188-
189176
Essential Git
190177
-------------
191178

192179
As the source code is handled by the version control system Git, it's useful to know some features used.
193180

194-
### Submodules ###
195-
196-
The repository uses submodules, which normally are handled directly by the `grunt update_submodules` command, but sometimes you want to
197-
be able to work with them manually.
198-
199-
Following are the steps to manually get the submodules:
200-
201-
```bash
202-
git clone https://github.com/jquery/jquery.git
203-
cd jquery
204-
git submodule init
205-
git submodule update
206-
```
207-
208-
Or:
209-
210-
```bash
211-
git clone https://github.com/jquery/jquery.git
212-
cd jquery
213-
git submodule update --init
214-
```
215-
216-
Or:
217-
218-
```bash
219-
git clone --recursive https://github.com/jquery/jquery.git
220-
cd jquery
221-
```
222-
223-
If you want to work inside a submodule, it is possible, but first you need to checkout a branch:
224-
225-
```bash
226-
cd src/sizzle
227-
git checkout master
228-
```
229-
230-
After you've committed your changes to the submodule, you'll update the jquery project to point to the new commit,
231-
but remember to push the submodule changes before pushing the new jquery commit:
232-
233-
```bash
234-
cd src/sizzle
235-
git push origin master
236-
cd ..
237-
git add src/sizzle
238-
git commit
239-
```
240-
241-
242181
### cleaning ###
243182

244183
If you want to purge your working directory back to the status of upstream, following commands can be used (remember everything you've worked on is gone after these):

bower.json

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"name": "jquery",
3+
"version": "2.0.4-pre",
4+
"ignore": [
5+
"**/.*",
6+
"build",
7+
"speed",
8+
"test",
9+
"CONTRIBUTING.md",
10+
"*.txt",
11+
"bower.json"
12+
],
13+
"dependencies": {
14+
"sizzle": "~1.10.4",
15+
"qunit": "~1.11.0"
16+
}
17+
}

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,12 @@
2323
],
2424
"dependencies": {},
2525
"devDependencies": {
26+
"grunt": "0.4.1",
2627
"grunt-compare-size": "~0.4.0",
2728
"grunt-git-authors": "1.2.0",
28-
"grunt-update-submodules": "0.2.0",
29-
"grunt-contrib-watch": "0.3.1",
30-
"grunt-contrib-jshint": "0.3.0",
31-
"grunt-contrib-uglify": "0.2.0",
32-
"grunt": "0.4.1",
29+
"grunt-contrib-watch": "~0.4.4",
30+
"grunt-contrib-jshint": "~0.6.0",
31+
"grunt-contrib-uglify": "~0.2.2",
3332
"gzip-js": "0.3.1",
3433
"testswarm": "~1.1.0",
3534
"archiver": "~0.4.2"

src/sizzle

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
55
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
66
<title>jQuery Test Suite</title>
7-
<link rel="Stylesheet" media="screen" href="qunit/qunit/qunit.css" />
7+
<link rel="Stylesheet" media="screen" href="../bower_components/qunit/qunit.css" />
88
<link rel="Stylesheet" media="screen" href="data/testsuite.css" />
99
<!-- Includes -->
1010

@@ -13,7 +13,7 @@
1313

1414
<script src="data/testinit.js"></script>
1515

16-
<script src="qunit/qunit/qunit.js"></script>
16+
<script src="../bower_components/qunit/qunit.js"></script>
1717
<script>
1818
(function() {
1919
var src = "../dist/jquery.min.js";
@@ -69,7 +69,7 @@
6969

7070
<!-- Subproject tests must be last because they replace our test fixture -->
7171
<script>
72-
testSubproject( "Sizzle", "../src/sizzle/test/", /^unit\/.*\.js$/ );
72+
testSubproject( "Sizzle", "../bower_components/sizzle/test/", /^unit\/.*\.js$/ );
7373
</script>
7474

7575
<script>

test/qunit

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)