Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Possible to replace any file when using Original Name Format #467

Closed
respektive opened this issue Sep 30, 2023 · 3 comments
Closed

Bug: Possible to replace any file when using Original Name Format #467

respektive opened this issue Sep 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@respektive
Copy link

What happened?

When setting the Format to Original Name like in the image below, it is possible to replace any already uploaded file if they share the same name and file extension.

Ideally there should be a check for already existing files. The upload could then be denied, or alternatively change the filename by appending a suffix or something like that.

Version

latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)

What browser(s) are you seeing the problem on?

Firefox

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response
@respektive respektive added the bug Something isn't working label Sep 30, 2023
@github-actions github-actions bot added this to the 3.7.1 milestone Sep 30, 2023
diced added a commit that referenced this issue Nov 6, 2023
@diced
fix: overwriting existing files #467
93cb9ee
@diced
Copy link
Owner

diced commented Nov 6, 2023

should be fixed in 93cb9ee
reopen if the issue happens again

@diced diced closed this as completed Nov 6, 2023
@respektive
Copy link
Author

respektive commented Nov 6, 2023 •
edited
Loading

Still happens on version 3.7.5 using the latest docker image. (also seems like i can't reopen the issue, only comment 🤔)

diced added a commit that referenced this issue Nov 11, 2023
@diced
fix: actually fix dupe files #467
b39507b
@diced
Copy link
Owner

diced commented Nov 11, 2023

ok its actually fixed in this b39507b

@diced diced closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@respektive @TacticalTechJay @diced