Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on the Neurons tab of the nns wallet #231

Open
LefterisJP opened this issue Oct 20, 2021 · 8 comments
Open

Improvements on the Neurons tab of the nns wallet #231

LefterisJP opened this issue Oct 20, 2021 · 8 comments
Labels
feature request New feature or request

Comments

@LefterisJP
Copy link

Hey guys so I have some requests/feedback for the neurons tab of the nns wallet dapp.

  1. It would be super super awesome to switch from these pill like things to a table format. This way you can know how many neurons you have easily. At the moment I need to count by hand and that does not work with many neurons.
  2. Provide an overall sum of the entire stake. There is no way to currently know how much ICP the user has staked across all neurons. This would help immensely.
  3. Show that staking amount in the ICP tab so one can have a full view of the ICP in their accounts.
  4. Allow toggle between staking end date and amount of dissolve delay.
    2021-10-20_18-36
    Would be nice to show an end date there.
  5. When the neurons tab becomes a table allow sorting it by dissolve delay, stake, maturity etc. This will be immensely helpful to manage one's neurons.
  6. Allow translation of maturity to ICP you can claim in the maturity tab
    2021-10-20_18-39
  7. Show the neuron's age bonus.
@lopezi
Copy link

lopezi commented Oct 20, 2021

  1. Order Neurons by Dissolving Date

@LefterisJP
Copy link
Author

  1. Order Neurons by Dissolving Date

I think this is same as (5). In a table format all these attributes would be a column in the table and you would just click on the column and it would sort by that attribute either ascending or descending.

@ielashi
Copy link
Contributor

ielashi commented Oct 21, 2021

Hi @LefterisJP, thanks a lot for the feedback. We'll be looking into incorporating these suggestions - no timelines to be communicated yet unfortunately, but we'll keep it in mind as we prioritize upcoming work.

@peterpeterparker
Copy link
Member

The neuron detail screen has change quite a lot since this issue was originally opened, therefore I gonna close it as I am doing a bit of clean up. Feel free to reopen actualized request if some has not been adressed.

@LefterisJP
Copy link
Author

Hey @peterpeterparker this is not even close to done. The changes that have been made to NNS are cosmetic and have nothing to do with what has been requested in this issue. Please read the description carefully.

  1. It would be super super awesome to switch from these pill like things to a table format.
  2. Provide an overall sum of the entire stake. There is no way to currently know how much ICP the user has staked across all neurons.
  3. Show that staking amount in the ICP tab so one can have a full view of the ICP in their accounts.
  4. Allow toggle between staking end date and amount of dissolve delay.
  5. When the neurons tab becomes a table allow sorting it by dissolve delay, stake, maturity etc. This will be immensely helpful to manage one's neurons. Generally filtering.
  6. Show the neuron's age bonus.

@peterpeterparker
Copy link
Member

peterpeterparker commented Dec 16, 2022

I see, thanks for the further explanation, reopening then.

  1. There are various task in the backlog about this. Not sure a table is the way because we should support also mobile devies but I understand your point. Will share the feedback.

  2. There are various discussions on the forum https://forum.dfinity.org/ about why ICP are not displayed. See notably threads about staking maturity.

  3. There are various discussions on the forum https://forum.dfinity.org/ about why ICP are not displayed. See notably threads about staking maturity.

  4. Out of curiosity, why knowing the precise date in advance would be useful for you?

  5. Same as 1.

  6. Same as 4, out of curiosity, what would this solve?

@LefterisJP
Copy link
Author

Hey @peterpeterparker regarding 2 and 3 I get it that things changed since I made the issue. I find that new way completely wrong and not fullfilling the purpose it was made for as I also stated in the forum. But anyway that

Out of curiosity, why knowing the precise date in advance would be useful for you?
Same as 4, out of curiosity, what would this solve?

I have many neurons. I would like to be able to list them by date of dissolution.

It would help me list them by age bonus, and understand which neurons would make sense to disburse and which to keep.

Generally the filtering by all possible attributes and searching for them is the biggest ask I have. Also showing them in a table format.

@peterpeterparker
Copy link
Member

peterpeterparker commented Dec 18, 2022

@LefterisJP thanks for the explanation, gotcha. Makes sense. I'll share your inputs with the team in our next Monday meeting. Cannot promise any ETA or else but, I'll share, that's a (re)-start.

@peterpeterparker peterpeterparker added the feature request New feature or request label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants