From 4bb4fdc8db411f5f5cc9d177d86572ce66107af7 Mon Sep 17 00:00:00 2001 From: Dmitry Filatov Date: Mon, 10 Sep 2018 10:45:33 +0300 Subject: [PATCH] Fix rendering to string of "draggable" attribute --- spec/renderToString/renderToString.spec.js | 8 ++++---- src/client/domAttrs.js | 7 ++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/spec/renderToString/renderToString.spec.js b/spec/renderToString/renderToString.spec.js index 95d18f4..dd40ba0 100644 --- a/spec/renderToString/renderToString.spec.js +++ b/spec/renderToString/renderToString.spec.js @@ -40,13 +40,13 @@ describe('renderToString', () => { }); it('should be rendered properly for overloaded with "true" attribute', () => { - expect(h('a', { download : true }).renderToString()) - .to.equal(''); + expect(h('div', { draggable : true }).renderToString()) + .to.equal('
'); }); it('should be rendered properly for overloaded with "false" attribute', () => { - expect(h('a', { download : false }).renderToString()) - .to.equal(''); + expect(h('div', { draggable : false }).renderToString()) + .to.equal('
'); }); it('shouldn\'t render null value', () => { diff --git a/src/client/domAttrs.js b/src/client/domAttrs.js index 9d7d152..778c8de 100644 --- a/src/client/domAttrs.js +++ b/src/client/domAttrs.js @@ -99,14 +99,10 @@ function removeSelectValue(node) { } function attrToString(name, value) { - if(value === false) { - return ''; - } - const attrName = getAttrName(name); return attrName && - attrName + (value === true? '' : '="' + escapeAttr(value) + '"'); + attrName + '="' + escapeAttr(value) + '"'; } function booleanAttrToString(name, value) { @@ -188,6 +184,7 @@ attrsCfg.autoPlay = BOOLEAN_ATTR_CFG; attrsCfg.checked = BOOLEAN_PROP_CFG; attrsCfg.controls = DEFAULT_PROP_CFG; attrsCfg.disabled = BOOLEAN_ATTR_CFG; +attrsCfg.download = BOOLEAN_ATTR_CFG; attrsCfg.id = DEFAULT_PROP_CFG; attrsCfg.ismap = BOOLEAN_ATTR_CFG; attrsCfg.loop = DEFAULT_PROP_CFG;