-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename __base
-> __super
and __self
-> __class
#38
Comments
__base
-> __super
and __self
-> __class
It will break backward compatibility without any reason. Is it actually needed? |
Yes, it will ;-) But we can do it in major version and also can keep both namigs for a while. The needs are derived from a fresh first look at stuff like bem-react-core, since there is no «backward compatibility» in this case. |
Frankly we can get rid of |
yeah! good point! |
|
let's up this ;-) we can provide back compatible pr |
Don't hesitate, just do it ) But I think we can release major version without backward compatibility since there won't be any new features so users can continue to use 2.x version without need to upgrade. |
Since it's more consistent with new JS classes API ;-)
The text was updated successfully, but these errors were encountered: