Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename __base -> __super and __self -> __class #38

Open
veged opened this issue Aug 8, 2017 · 7 comments
Open

Rename __base -> __super and __self -> __class #38

veged opened this issue Aug 8, 2017 · 7 comments

Comments

@veged
Copy link

veged commented Aug 8, 2017

Since it's more consistent with new JS classes API ;-)

@veged veged changed the title Rename __base -> __super and __self -> __class Rename __base -> __super and __self -> __class Aug 8, 2017
@dfilatov
Copy link
Owner

dfilatov commented Aug 8, 2017

It will break backward compatibility without any reason. Is it actually needed?

@veged
Copy link
Author

veged commented Aug 9, 2017

Yes, it will ;-) But we can do it in major version and also can keep both namigs for a while.

The needs are derived from a fresh first look at stuff like bem-react-core, since there is no «backward compatibility» in this case.

@dfilatov dfilatov closed this as completed Aug 9, 2017
@dfilatov dfilatov reopened this Aug 9, 2017
@dfilatov
Copy link
Owner

dfilatov commented Aug 9, 2017

Frankly we can get rid of __self property at all because it just duplicates constructor.

@veged
Copy link
Author

veged commented Aug 10, 2017

yeah! good point!

@awinogradov
Copy link

__super 👍

@veged
Copy link
Author

veged commented Feb 21, 2018

let's up this ;-) we can provide back compatible pr

@dfilatov
Copy link
Owner

let's up this ;-) we can provide back compatible pr

Don't hesitate, just do it ) But I think we can release major version without backward compatibility since there won't be any new features so users can continue to use 2.x version without need to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants