You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.
Does this PR introduce a user-facing change?
Summary by Bito
Fixes a bug in the slice initialization within the BuildPipelineRestHandler.go file, ensuring the slice is initialized with the correct capacity based on the length of cdPipelines, which prevents potential runtime errors related to slice operations.
Improves memory efficiency by correctly initializing the slice.
Overall summary: addresses a bug in slice initialization in BuildPipelineRestHandler.go, which fixes potential runtime errors.
️✅ There are no secrets present in this pull request anymore.
If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xihuwenhua
requested review from
nishant-d,
prakarsh-dt and
vikramdevtron
as code owners
Description
The intention here should be to initialize a slice with a capacity of len(cdPipelines) rather than initializing the length of this slice.
The online demo: https://go.dev/play/p/vNUPNjdb2gJ
Fixes #
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito