Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance for transferring proto comments directly above a field to "$comment" keyword inside the json type? #10

Open
iguberman opened this issue Jan 21, 2019 · 0 comments

Comments

@iguberman
Copy link

i.e. PROTO:

message TIMESTAMP {
        // Represents seconds of UTC time since Unix epoch
        required int64 seconds = 1;   

        // Non-negative fractions of a second at millisecond resolution
        required int32 millis = 2;        
}

JSON SCHEMA:

"TIMESTAMP": {
      "title": "TIMESTAMP",
      "type": "object",
      "properties": {
        "seconds": {
          "type": "integer",
          "minimum": -9007199254740991,
          "maximum": 9007199254740991,
          "$comment" : "Represents seconds of UTC time since Unix epoch"
        },
        "millis": {
          "type": "integer",
          "minimum": -2147483648,
          "maximum": 2147483647,
          "$comment" : "Non-negative fractions of a second at millisecond resolution",
        }
      },
      "required": [
        "seconds",
        "millis"
      ]
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant