Fixed issues related to lint- migration to devon4j

Author: vapadwal

angular/src/app/cockpit-area/order-cockpit/order-cockpit.component.ts

@@ -24,7 +24,7 @@ export class OrderCockpitComponent implements OnInit {
   private pageable: Pageable = {
     pageSize: 8,
     pageNumber: 0,
-    //total: 1,
+    // total: 1,
   };
   private sorting: any[] = [];
 
@@ -69,10 +69,9 @@ export class OrderCockpitComponent implements OnInit {
   applyFilters(): void {
     this.waiterCockpitService.getOrders(this.pageable, this.sorting, this.filters)
       .subscribe((data: any) => {
-        if (data == null) {
+        if (!data) {
         this.orders = [];
-        }
-        else{
+        } else {
           this.orders = data.content;
         }
         this.totalOrders = data.totalElements;
@@ -89,7 +88,6 @@ export class OrderCockpitComponent implements OnInit {
       pageSize: pagingEvent.pageSize,
       pageNumber: pagingEvent.page - 1,
       sort: this.pageable.sort,
-      //total: 1,
     };
     this.applyFilters();
   }
@@ -100,7 +98,7 @@ export class OrderCockpitComponent implements OnInit {
       property: sortEvent.name,
       direction: '' + sortEvent.order,
     });
-   this.applyFilters();
+    this.applyFilters();
   }
 
   selected(selection: ITdDataTableSelectAllEvent): void {

angular/src/app/cockpit-area/reservation-cockpit/reservation-cockpit.component.ts

@@ -27,7 +27,7 @@ export class ReservationCockpitComponent implements OnInit {
   pageable: Pageable = {
     pageSize: 8,
     pageNumber: 0,
-    //total: 1,
+    // total: 1,
   };
 
   reservations: ReservationView[];
@@ -74,9 +74,9 @@ export class ReservationCockpitComponent implements OnInit {
   applyFilters(): void {
     this.waiterCockpitService.getReservations(this.pageable, this.sorting, this.filters)
       .subscribe((data: any) => {
-        if(data == null){
+        if (!data) {
           this.reservations = [];
-        }else{
+        } else {
           this.reservations = data.content;
         }
         this.totalReservations = data.totalElements;
@@ -93,7 +93,7 @@ export class ReservationCockpitComponent implements OnInit {
       pageSize: pagingEvent.pageSize,
       pageNumber: pagingEvent.page - 1,
       sort: this.pageable.sort,
-      //total: 1,
+      // total: 1,
     };
     this.applyFilters();
   }

angular/src/app/menu/menu.component.ts

@@ -24,11 +24,6 @@ export class MenuComponent {
 
   dishes$: Observable<DishView[]>;
 
-  /*pageable: Pageable = {
-    pageSize: 8,
-    pageNumber: 0,
-  };*/
-
   constructor(
     private menuService: MenuService,
   ) {}
@@ -39,16 +34,15 @@ export class MenuComponent {
       pageNumber: 0,
       sort: [{
         property: filters.sort.property,
-        direction: filters.sort.direction
-      }]
-    }; 
-    const composedFilters: Filter = this.menuService.composeFilters(pageable,filters);
+        direction: filters.sort.direction,
+      }],
+    };
+    const composedFilters: Filter = this.menuService.composeFilters(pageable, filters);
     this.dishes$ = this.menuService.getDishes(composedFilters).pipe(
-      map((res) => 
-      {
-        if(res==null){
+      map((res) => {
+        if (!res) {
         return [];
-      }else{
+      } else {
         return res.content;
       }
       }),

angular/src/app/menu/shared/menu.service.ts

@@ -36,14 +36,14 @@ export class MenuService {
     };
   }
 
-  composeFilters(pageable: Pageable,filters: FilterFormData): Filter {
+  composeFilters(pageable: Pageable, filters: FilterFormData): Filter {
     const categories: { id: string }[] = Object.keys(filters.categories)
         .filter((categoryKey: string) => filters.categories[categoryKey])
         .map((categoryKey: string) => ({id: categoryNameToServerId[categoryKey].toString()}));
-    if (filters.sort.property == null) {
-     filters.sort = null;
-      pageable.sort = null;
-   } 
+    if (!filters.sort.property) {
+      filters.sort = undefined;
+      pageable.sort = undefined;
+   }
 
     return {
         categories,

java/mtsj/pom.xml

@@ -12,7 +12,7 @@
 
   <properties>
     <spring.boot.version>2.0.4.RELEASE</spring.boot.version>
-   <devon4j.version>3.0.0-alpha.1</devon4j.version>
+   <devon4j.version>3.0.0</devon4j.version>
     <java.version>1.8</java.version>
     <devon.port.range>81</devon.port.range>
     <devon.http.port>${devon.port.range}81</devon.http.port>