Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devon4j templates - ETO should derive from RevisionedEto rather than AbstractEto #768

Open
jdiazgon opened this issue Oct 5, 2018 · 3 comments
Labels
Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates templates

Comments

@jdiazgon
Copy link
Member

jdiazgon commented Oct 5, 2018

On devon4j, in case some project is using Envers via RevisionedPersistenceEntity:

We would have an entity implementing RevisionedPersistenceEntity (or RevisionedEntity). Using that entity as input. the generated ETO should derive from RevisionedEto rather than AbstractEto.

Related PRs

devon4j#16.

Related issues

#751

@maybeec
Copy link
Member

maybeec commented Oct 10, 2018

This should be an opt in right? Otherwise, you would do that for everyone, which is mostly not needed.

@hohwille
Copy link
Member

Yep, I also agree. Pseudocode:

if (pojo instanceof RevisionedPersistenceEntity) {
  generateWithBaseClassIfNothingElseToExtend(RevisionedEto.class);
} else {
  generateWithBaseClassIfNothingElseToExtend(AbstractEto.class);
}

Please note that this applies to both spring-data as well as DAO in devon4j.

@github-actions
Copy link

Stale issue message

@maybeec maybeec added the Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates templates
Projects
None yet
Development

No branches or pull requests

3 participants