Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adaption of template sets #1455

Closed
2 tasks
maybeec opened this issue Jan 10, 2022 · 2 comments · Fixed by #1520
Closed
2 tasks

Allow adaption of template sets #1455

maybeec opened this issue Jan 10, 2022 · 2 comments · Fixed by #1520
Assignees
Labels
comp:core prio:high proc:estimated Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates
Milestone

Comments

@maybeec
Copy link
Member

maybeec commented Jan 10, 2022

As a user, I want to be able to adapt templates so that I can change templates up to my needs for my project.
Template sets should be adaptable independently. The user needs to decide which template set she wants to adapt.

Acceptance Criteria:

  • core is adapted and provides a proper interface and implementation to adapt any specific template set
  • if a template-set to be adapted is not currently installed, core should raise an exception
@maybeec maybeec added the Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates label Jan 10, 2022
@GuentherJulian GuentherJulian self-assigned this Apr 12, 2022
@GuentherJulian
Copy link
Contributor

How should we proceed if there is an old configuration with one 'big' jar file? Should the adaption work as before or should we log something like this is no longer supported and the user should update the configuration to the new structure consisting of template sets?
I think if the user has not adapted the templates until this point, then he should go with the new structure. Should the configuration be changed automatically so that the old template folder is deleted and replaced with the new structure?

@maybeec
Copy link
Member Author

maybeec commented Apr 13, 2022

  1. extract in old style
  2. ask user to continue with upgrade of configuration (reuse Add functionality to contextConfigurationUpgrader to upgrade to config v3.0+ #1502)
  3. if confirms, trigger Add functionality to contextConfigurationUpgrader to upgrade to config v3.0+ #1502 logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:core prio:high proc:estimated Team_CobiGen_Templates These issues will be handeled by the team CobiGen_Templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants