From 7a2022f154f60fb4ba781e4585d0b04b34448329 Mon Sep 17 00:00:00 2001
From: jdiazgon <31688036+jdiazgon@users.noreply.github.com>
Date: Fri, 10 Jan 2020 10:10:52 +0100
Subject: [PATCH 01/15] Fixing license
---
cobigen/pom.xml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cobigen/pom.xml b/cobigen/pom.xml
index d377271408..a54916b041 100644
--- a/cobigen/pom.xml
+++ b/cobigen/pom.xml
@@ -138,8 +138,7 @@
true
${project.name}
- {maven-resources}, {maven-dependencies}
- {maven-resources}, {maven-dependencies}, {META-INF/LICENSE.html=src/main/resources/META-INF/LICENSEP2BUNDLE.html}
+ {maven-resources}, {maven-dependencies}, {META-INF/LICENSE.html=src/main/resources/META-INF/LICENSEP2BUNDLE.html}
true
From 29bf2a4227020e9f6f10a0bda3902039d88587f1 Mon Sep 17 00:00:00 2001
From: Jaime Diaz
Date: Fri, 10 Jan 2020 10:46:39 +0100
Subject: [PATCH 02/15] #1093 Set next development version
---
.../cobigen-openapiplugin-model/pom.xml | 2 +-
.../cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin-model/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin-model/pom.xml
index a781c4a990..944d092eb8 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin-model/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin-model/pom.xml
@@ -1,7 +1,7 @@
4.0.0
openapiplugin-model
- 2.4.0-SNAPSHOT
+ 2.5.0-SNAPSHOT
CobiGen Openapiplugin Model
jar
CobiGen - OpenAPI Plug-in Model
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
index 458b8e790b..c6dde935e9 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
@@ -2,7 +2,7 @@
4.0.0
openapiplugin
CobiGen - Open API Plug-in
- 2.4.0-SNAPSHOT
+ 2.5.0-SNAPSHOT
jar
CobiGen - OpenAPI Plug-in
From 79a1c1f268366693897d61943e0872540114c558 Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Tue, 14 Apr 2020 08:36:21 +0200
Subject: [PATCH 03/15] #1083 fix snapshot retrieval of sonartype snapshot
repository
(cherry picked from commit 7e2f0b4a11f40656b172d565540624b26cb98caf)
---
pom.xml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/pom.xml b/pom.xml
index a96c6cf8f6..7d22b59348 100644
--- a/pom.xml
+++ b/pom.xml
@@ -525,4 +525,18 @@
https://oss.sonatype.org/content/repositories/snapshots/
+
+
+
+ sonartype.snapshots
+ OSSRH Snapshots
+ https://oss.sonatype.org/content/repositories/snapshots/
+
+ true
+
+
+ false
+
+
+
From 1792c714c1fd96058d09a7baeac970a0a192db4a Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Tue, 14 Apr 2020 09:14:33 +0200
Subject: [PATCH 04/15] #1083 fix tests for jdk8 with jdk11 support
---
.../cobigen-openapiplugin/pom.xml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
index eed9eb1e07..fada11707d 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
@@ -26,7 +26,7 @@
com.devonfw.cobigen
core-api
- 5.3.0
+ 6.0.0
com.reprezen.kaizen
@@ -43,13 +43,13 @@
com.devonfw.cobigen
core-test
- 6.0.0
+ 6.1.0-SNAPSHOT
test
com.devonfw.cobigen
core
- 6.0.0
+ 6.1.0-SNAPSHOT
test
From c406415281547da00e0be62cadf56330545bcfe9 Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Tue, 14 Apr 2020 09:24:31 +0200
Subject: [PATCH 05/15] #1083 fix build
---
.../cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
index fada11707d..9e99382da8 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
@@ -26,7 +26,7 @@
com.devonfw.cobigen
core-api
- 6.0.0
+ 6.1.0-SNAPSHOT
com.reprezen.kaizen
From 63ef1a2d670cec262c625543acb88b08b6eb722f Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Thu, 10 Sep 2020 00:21:40 +0200
Subject: [PATCH 06/15] #1228 adapt to new lazy activation API
---
.../cobigen-openapiplugin/pom.xml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
index 9e99382da8..1f8b960d37 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
@@ -26,7 +26,7 @@
com.devonfw.cobigen
core-api
- 6.1.0-SNAPSHOT
+ [6.2.0-SNAPSHOT,)
com.reprezen.kaizen
@@ -43,19 +43,19 @@
com.devonfw.cobigen
core-test
- 6.1.0-SNAPSHOT
+ [6.2.0-SNAPSHOT,)
test
com.devonfw.cobigen
core
- 6.1.0-SNAPSHOT
+ [6.2.0-SNAPSHOT,)
test
com.devonfw.cobigen
tempeng-freemarker
- 2.0.0
+ 2.0.2-SNAPSHOT
test
From a8c18de8bd50800ac768042b0196ea01a72499f6 Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Thu, 10 Sep 2020 00:22:07 +0200
Subject: [PATCH 07/15] #1228 adapt to new lazy activation API
---
.../cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
index 1f8b960d37..b1ce04d8b6 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/pom.xml
@@ -55,7 +55,7 @@
com.devonfw.cobigen
tempeng-freemarker
- 2.0.2-SNAPSHOT
+ 2.2.0-SNAPSHOT
test
From f331f18a97df0273df6f024e5959f8e18289e7f7 Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Thu, 10 Sep 2020 00:35:02 +0200
Subject: [PATCH 08/15] #1228 adapt to new lazy activation API
---
.../openapiplugin/OpenAPIPluginActivator.java | 3 +++
.../openapiplugin/OpenAPITriggerInterpreter.java | 3 +++
.../inputreader/OpenAPIInputReader.java | 16 +++++++++-------
3 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPIPluginActivator.java b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPIPluginActivator.java
index f00a2c6951..384efe2ecb 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPIPluginActivator.java
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPIPluginActivator.java
@@ -2,14 +2,17 @@
import java.util.List;
+import com.devonfw.cobigen.api.annotation.Activation;
import com.devonfw.cobigen.api.extension.GeneratorPluginActivator;
import com.devonfw.cobigen.api.extension.Merger;
import com.devonfw.cobigen.api.extension.TriggerInterpreter;
+import com.devonfw.cobigen.openapiplugin.inputreader.OpenAPIInputReader;
import com.google.common.collect.Lists;
/**
* Plug-in activator to be registered at CobiGen.
*/
+@Activation(byFileExtension = { OpenAPIInputReader.VALID_EXTENSION_YAML, OpenAPIInputReader.VALID_EXTENSION_YML })
public class OpenAPIPluginActivator implements GeneratorPluginActivator {
/**
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPITriggerInterpreter.java b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPITriggerInterpreter.java
index b2a9ffd80c..97353ce777 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPITriggerInterpreter.java
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/OpenAPITriggerInterpreter.java
@@ -1,7 +1,9 @@
package com.devonfw.cobigen.openapiplugin;
+import com.devonfw.cobigen.api.annotation.ReaderPriority;
import com.devonfw.cobigen.api.extension.InputReader;
import com.devonfw.cobigen.api.extension.MatcherInterpreter;
+import com.devonfw.cobigen.api.extension.Priority;
import com.devonfw.cobigen.api.extension.TriggerInterpreter;
import com.devonfw.cobigen.openapiplugin.inputreader.OpenAPIInputReader;
import com.devonfw.cobigen.openapiplugin.matcher.OpenAPIMatcher;
@@ -9,6 +11,7 @@
/**
* {@link TriggerInterpreter} implementation of a Swagger Interpreter
*/
+@ReaderPriority(Priority.LOW)
public class OpenAPITriggerInterpreter implements TriggerInterpreter {
/**
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/inputreader/OpenAPIInputReader.java b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/inputreader/OpenAPIInputReader.java
index 35aa299155..c9f3922f21 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/inputreader/OpenAPIInputReader.java
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/main/java/com/devonfw/cobigen/openapiplugin/inputreader/OpenAPIInputReader.java
@@ -33,7 +33,6 @@
import com.devonfw.cobigen.openapiplugin.model.ResponseDef;
import com.devonfw.cobigen.openapiplugin.model.ServerDef;
import com.devonfw.cobigen.openapiplugin.util.constants.Constants;
-import com.jayway.jsonpath.Configuration;
import com.reprezen.jsonoverlay.JsonOverlay;
import com.reprezen.jsonoverlay.Overlay;
import com.reprezen.jsonoverlay.Reference;
@@ -55,6 +54,12 @@
*/
public class OpenAPIInputReader implements InputReader {
+ /** Valid extensions for the input reader */
+ public static final String VALID_EXTENSION_YAML = "yaml";
+
+ /** Valid extensions for the input reader */
+ public static final String VALID_EXTENSION_YML = "yml";
+
/**
* Components retrieved from an EntityDef. Used for not executing multiple times the retrieval of
* components
@@ -215,7 +220,6 @@ private ComponentDef getComponent(String componentName) {
* @return list of entities
*/
private List extractComponents(OpenApi3 openApi) {
- Object document = Configuration.defaultConfiguration().jsonProvider().parse(Overlay.toJson(openApi).toString());
HeaderDef header = new HeaderDef();
header.setServers(extractServers(openApi));
header.setInfo(extractInfo(openApi));
@@ -227,7 +231,7 @@ private List extractComponents(OpenApi3 openApi) {
entityDef.setName(key);
entityDef.setDescription(openApi.getSchema(key).getDescription());
ComponentDef componentDef = new ComponentDef();
- entityDef.setProperties(extractProperties(openApi, document, key));
+ entityDef.setProperties(extractProperties(openApi, key));
// If no x-component tag was found on the input file, throw invalid configuration
if (openApi.getSchema(key).getExtensions().get(Constants.COMPONENT_EXT) == null) {
@@ -348,13 +352,11 @@ private PropertyDef extractReferenceProperty(OpenApi3 openApi, Schema componentS
*
* @param openApi
* the OpenApi3 model
- * @param jsonDocument
- * parsed JSON document
* @param componentName
* entity name
* @return List of {@link PropertyDef}'s
*/
- private List extractProperties(OpenApi3 openApi, Object jsonDocument, String componentName) {
+ private List extractProperties(OpenApi3 openApi, String componentName) {
Schema componentSchema = openApi.getSchema(componentName);
Map properties = componentSchema.getProperties();
List objects = new LinkedList<>();
@@ -698,7 +700,7 @@ public Object read(java.nio.file.Path path, Charset inputCharset, Object... addi
@Override
public boolean isMostLikelyReadable(java.nio.file.Path path) {
- List validExtensions = Arrays.asList("yaml", "yml");
+ List validExtensions = Arrays.asList(VALID_EXTENSION_YAML, VALID_EXTENSION_YML);
String fileExtension = FilenameUtils.getExtension(path.toString()).toLowerCase();
return validExtensions.contains(fileExtension);
}
From 23bec0d39c6c80d086e0f97f992902a8294d9bcf Mon Sep 17 00:00:00 2001
From: Malte Brunnlieb
Date: Thu, 10 Sep 2020 00:57:05 +0200
Subject: [PATCH 09/15] #1228 fix tests
---
.../InputReaderMatcherTest.java | 28 +++++++------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/test/java/com/devonfw/cobigen/openapiplugin/integrationtest/InputReaderMatcherTest.java b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/test/java/com/devonfw/cobigen/openapiplugin/integrationtest/InputReaderMatcherTest.java
index c2054ebe6e..de52964f20 100644
--- a/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/test/java/com/devonfw/cobigen/openapiplugin/integrationtest/InputReaderMatcherTest.java
+++ b/cobigen/cobigen-openapiplugin-parent/cobigen-openapiplugin/src/test/java/com/devonfw/cobigen/openapiplugin/integrationtest/InputReaderMatcherTest.java
@@ -15,7 +15,6 @@
import com.devonfw.cobigen.api.to.GenerationReportTo;
import com.devonfw.cobigen.api.to.TemplateTo;
import com.devonfw.cobigen.impl.CobiGenFactory;
-import com.devonfw.cobigen.openapiplugin.model.OpenAPIFile;
import com.devonfw.cobigen.openapiplugin.util.TestConstants;
import junit.framework.AssertionFailedError;
@@ -42,8 +41,7 @@ public class InputReaderMatcherTest {
public void testBasicElementMatcher_oneComponent() throws Exception {
CobiGen cobigen = CobiGenFactory.create(Paths.get(testdataRoot, "templates").toUri());
- Object openApiFile =
- cobigen.read("openapi", Paths.get(testdataRoot, "one-component.yaml"), TestConstants.UTF_8);
+ Object openApiFile = cobigen.read(Paths.get(testdataRoot, "one-component.yaml"), TestConstants.UTF_8);
assertThat(openApiFile).isNotNull();
List