Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#894: Fix ide.bat printing for initialization and error output #902

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#894: Fix ide.bat printing for initialization and error output #902

wants to merge 4 commits into from

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Dec 17, 2024 •
edited
Loading

Fixes: #894

This PR fixes ide.bat to print the correct output when an error occurs or ideasy is initialized.

@alfeilex
Copy link
Member Author

23a6924 fixes that the correct errorlevel is used. Here an example to see the difference

if not "%1%" == "" (
  ideasy %IDE_OPTIONS% %*
  echo test %ERRORLEVEL% 
  goto :output_error
)

:output_error
echo inside %ERRORLEVEL%
if not %ERRORLEVEL% == 0 (
	echo %_fBRed%Error: IDEasy failed with exit code %ERRORLEVEL% %_RESET%
	exit /b %ERRORLEVEL%
  )

@coveralls
Copy link
Collaborator

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12376939489

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.478%
Totals Coverage Status
Change from base Build 12375027220: 0.0%
Covered Lines: 6656
Relevant Lines: 9523
💛 - Coveralls

@alfeilex alfeilex changed the title #894: Fix ide.bat printing for initialize and error output #894: Fix ide.bat printing for initialization and error output Dec 17, 2024
@alfeilex alfeilex self-assigned this Dec 17, 2024
@alfeilex alfeilex marked this pull request as ready for review December 17, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alfeilex alfeilex

Labels
None yet
Projects
IDEasy board
Status: Team Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ide.bat not printing if IDEasy was initialized
2 participants
@alfeilex @coveralls