various "printf: x%: not completely converted" errors

[ralsei]

λ d /etc/wiconfig iwm0
doas (arc@terra.arcetera.moe) password: 
Currently connected to <SSID>.
Would you like to connect to a different network (y/n)? y
Performing wireless scan...
printf: 79%: not completely converted
printf: 64%: not completely converted
printf: 46%: not completely converted
printf: 43%: not completely converted
printf: 43%: not completely converted
printf: 41%: not completely converted
printf: 38%: not completely converted
printf: 31%: not completely converted
printf: 31%: not completely converted
printf: 29%: not completely converted
printf: 26%: not completely converted
printf: 26%: not completely converted
printf: 25%: not completely converted
printf: 25%: not completely converted
printf: 23%: not completely converted
printf: 23%: not completely converted
printf: 22%: not completely converted
printf: 17%: not completely converted
printf: 11%: not completely converted
<SSID> found.  Would you like to reconnect (y/n)? 

[brycied00d]

I just tested this running the latest current and wasn't able to reproduce your issue. Could you provide a few more details:

1. OpenBSD release you're running
2. The output from ifconfig iwm0 scan on your system.

It's possible that there's an SSID around you that's got some funky characters that's breaking up a split, or something else "funny" about ifconfig's scan output in your release.

[brycied00d]

After a bit of coincidental investigation (related to a project of @qbit's) I understand now that ifconfig scan will output network signal strength in % if the interface driver knows/has the maximum RSSI of the device. If the maximum RSSI is not known to the driver, then ifconfig scan shows signal strength in the relatively absolute dBm.

Sounds like wiconfig needs to be adjusted to handle both cases cleanly, escaping % when passing the string through printf.

[ralsei]

Yes, I noticed that when switching from my laptop's built-in iwm card to a run USB dongle.