Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some way of defining readiness/liveness checks for DevWorkspaces #1228

Open
amisevsk opened this issue Jan 30, 2024 · 0 comments
Open

Add some way of defining readiness/liveness checks for DevWorkspaces #1228

amisevsk opened this issue Jan 30, 2024 · 0 comments

Comments

@amisevsk
Copy link
Collaborator

Description

Currently, the DevWorkspace Operator will do a rudimentary liveness check on workspaces by making a http get request at the workspace's <mainUrl>/healthz. However, in order to not break applications that do not implement /healthz, it has to treat 4xx staus codes as successes, meaning the health check doesn't do a whole lot for most workloads.

Instead, we should define some way of specifying actual readiness/liveness probes for workspaces, allowing e.g. the Code editor running in the pod to prevent the workspace entering a running state until it is ready to serve requests.

It should be possible to implement a workaround for this by using pod-overrides and container-overrides, but perhaps a more formal attribute or similar would be useful here.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant