Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the ConfigMap / changing env vars does not force containers to restart #72

Open
batpad opened this issue Feb 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@batpad
Copy link
Member

batpad commented Feb 6, 2024

Currently, if you change an environment variable for one of the containers, of edit the ConfigMap, it does not automatically restart the affected containers - i.e. the environment variable does not propagate to the container with a deploy, and it needs a manual restart of the container for the environment variables to propagate.

Steps to Reproduce:

  • Change an environment variable in values.yaml
  • Deploy

Expected:

  • My changed environment variable to be on the container

Actual:

  • The container does not restart because it does not know the ConfigMap has changed.

From chat with @ranchodeluxe on Slack:

"personally I'd just make my CI/CD bounce all services at deploy time and then you don't have to worry"

That sounds good to me. Another option would be to use an annotation on the deployments that's a hash of the ConfigMap, so if the ConfigMap changes, the hash changes, and that would force a container restart.

This is not urgent, just wanted to drop the issue so as not to forget.

cc @ranchodeluxe @sunu

@batpad batpad added the bug Something isn't working label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant